Repository navigation
gh-121528: Fix the process crash when load extension when it's compiled with low version of the python. - #121550
Closed
Zheaoli wants to merge 5 commits into
Closed
Zheaoli wants to merge 5 commits into
Zheaoli wants to merge 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…d with low version of the python
ZeroIntensity
requested changes
Jul 9, 2024
ZeroIntensity
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Can confirm that this PR fixes #121528
Sorry, something went wrong.
Comment thread
Include/internal/pycore_object.h
Outdated
Copy link
Copy Markdown
Member
|
@Eclips4 Can you add the 3.13 backport label? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
cc @mgorny can you confirm that this patch fixes the issue? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
I can confirm that rustworkx no longer crashes with this patch applied. |
Sorry, something went wrong.
ZeroIntensity
requested changes
Jul 10, 2024
Comment thread
Misc/NEWS.d/next/Core_and_Builtins/2024-07-10-03-13-19.gh-issue-121528._Bo7rw.rst
Outdated
Comment thread
Misc/NEWS.d/next/Core_and_Builtins/2024-07-10-03-13-19.gh-issue-121528._Bo7rw.rst
Outdated
…e-121528._Bo7rw.rst Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
…e-121528._Bo7rw.rst Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Copy link
Copy Markdown
Contributor
Author
|
@ZeroIntensity Thanks for the nits! |
Sorry, something went wrong.
ZeroIntensity
approved these changes
Jul 10, 2024
ZeroIntensity
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks for the changes, LGTM.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #121528