GH-120754: Make PY_READ_MAX smaller than max byteobject size - #121633
Closed
cmaloney wants to merge 4 commits into
Closed
GH-120754: Make PY_READ_MAX smaller than max byteobject size#121633cmaloney wants to merge 4 commits into
cmaloney wants to merge 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Currently if code tries to do a os.read larger than the max bytes object length, the size to read gets capped to `_PY_READ_MAX`, then the code tries to allocate a PyBytes which fails with an OverflowError as the size is larger than the max py bytes object. Since os.read is capping the max size anyways, cap it to a size which is always allocatable as a PyBytes. This changes behavior from bpo-21932 and enables the large file os.read test on 32 bit platforms, as it should cap the read to a platform acceptable size.
cmaloney
commented
Jul 15, 2024
Comment thread
Misc/NEWS.d/next/Core and Builtins/2024-07-11-13-57-50.gh-issue-120754.C1HedA.rst
Outdated
| Cap read size to smaller than the max BytesObject size. read() in POSIX | ||
| returns at most the number of requseted bytes, this updates python ``os.read`` | ||
| to do similarly, and rather than throw an OverflowError in this case, return | ||
| a smaller than requseted byte object. |
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
requested
Sorry, something went wrong.
cmaloney
commented
Jul 17, 2024
Comment thread
Lib/test/test_os.py
| # Py_ssize_t type | ||
| @unittest.skipUnless(INT_MAX < PY_SSIZE_T_MAX, | ||
| "needs INT_MAX < PY_SSIZE_T_MAX") | ||
| @support.bigmemtest(size=INT_MAX + 10, memuse=1, dry_run=False) |
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
issue here is that this will result in a memory allocation error on 32 bit machines, and this bigmemtest effectively makes it not run on 32 bit machines (They are unlikely to have that much RAM)
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if code tries to do a os.read larger than the max bytes object length, the size to read gets capped to _PY_READ_MAX, then the code tries to allocate a PyBytes which fails with an OverflowError as the size is longer than what is allocatable.
Since os.read is capping the max size anyways, cap it to a size which is always allocatable as a PyBytes.
This changes behavior from bpo-21932 and enables the large file os.read test on 32 bit platforms, as it should cap the read to a platform acceptable size.