gh-121617: Include string.h in pwdmodule.c if _Py_TYPEOF is undefined - #121643
gh-121617: Include string.h in pwdmodule.c if _Py_TYPEOF is undefined#121643fuhsnn wants to merge 1 commit into
Conversation
Sorry, something went wrong.
…efined If _Py_TYPEOF is undefined, Py_CLEAR falls back to an implementation with memcpy() call; conditionally include the missing string.h dependency.
|
All commit authors signed the Contributor License Agreement. |
Sorry, something went wrong.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead. |
Sorry, something went wrong.
vstinner
left a comment
There was a problem hiding this comment.
This change is outdated: the pwd extension is no longer built with the limited C API.
Also, it's not the proper fix: Python.h should include <string.h> if the _Py_TYPEOF macro is not defined. I wrote #144666 change to do that.
Sorry, something went wrong.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request. |
Sorry, something went wrong.
If _Py_TYPEOF is undefined, Py_CLEAR falls back to an implementation with memcpy() call; conditionally include the missing string.h dependency.