gh-121637: Syntax error for optimized-away incorrect await - #121656
Merged
JelleZijlstra merged 10 commits intoJul 22, 2024
Merged
gh-121637: Syntax error for optimized-away incorrect await#121656JelleZijlstra merged 10 commits into
JelleZijlstra merged 10 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
JelleZijlstra
requested review from
carljm,
iritkatriel and
markshannon
as code owners
July 13, 2024 01:22
picnixz
reviewed
Jul 13, 2024
picnixz
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Some minor comments.
Sorry, something went wrong.
Comment thread
Doc/whatsnew/3.14.rst
Outdated
Comment thread
Python/compile.c
Outdated
Comment thread
Python/symtable.c
Outdated
Comment thread
Python/symtable.c
Outdated
Comment thread
Python/symtable.c
Outdated
Comment thread
Python/symtable.c
Comment thread
Python/symtable.c
Outdated
Comment thread
Python/symtable.c
Comment thread
Misc/NEWS.d/next/Core and Builtins/2024-07-12-18-18-44.gh-issue-121297.67VE7b.rst
Outdated
JelleZijlstra
marked this pull request as draft
July 13, 2024 01:40
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Copy link
Copy Markdown
Member
Author
|
@picnixz while you're here, would you mind emailing me (jelle.zijlstra@gmail.com) or sending me a DM on https://discuss.python.org/u/jelle? I have something I want to ask you. |
Sorry, something went wrong.
JelleZijlstra
marked this pull request as ready for review
July 13, 2024 02:04
Copy link
Copy Markdown
Member
Well.. I just went to sleep at that time. I've just sent you an email, tell me if you didn't receive it! |
Sorry, something went wrong.
picnixz
reviewed
Jul 17, 2024
Comment thread
Python/compile.c
iritkatriel
approved these changes
Jul 21, 2024
iritkatriel
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks, this is a good change.
Sorry, something went wrong.
picnixz
reviewed
Jul 22, 2024
Comment thread
Python/compile.c
iritkatriel
reviewed
Jul 22, 2024
Comment thread
Lib/test/test_builtin.py
Outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--121656.org.readthedocs.build/