gh-121651: Fix pdb header test - #121724
Merged
gaogaotiantian merged 2 commits intoJul 13, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@Eclips4 feel free to take a look at this fix and confirm this works. I tried it locally and ./python -m test test_pdb --forever worked fine. |
Sorry, something went wrong.
Eclips4
approved these changes
Jul 13, 2024
Eclips4
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
@Eclips4 feel free to take a look at this fix and confirm this works. I tried it locally and ./python -m test test_pdb --forever worked fine.
Yes, I can confirm that this fixes the problem. Thanks!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the header test for pdb.set_trace, we redirected stdout to a string buffer, but that would only work when we create the Pdb instance after the patch. Due to the changes in #121451 , that's not always guaranteed. So for this test, we clear the Pdb._last_pdb_instance before pdb.set_trace(), which enforces pdb.set_trace() to create a new Pdb instance which has the redirected stdout.