gh-121295: Fix blocked console after interrupting a long paste - #121815
Merged
ambv merged 3 commits intoJul 15, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
ZeroIntensity
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Confirmed that this fixes #121295
Sorry, something went wrong.
Comment on lines
+1
to
+2
| Fix PyREPL console getting into a blocked state after interrupting a long | ||
| paste |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Tiny wording nitpick:
Suggested change
| Fix PyREPL console getting into a blocked state after interrupting a long | |
| paste | |
| Fixed REPL getting into a blocked state after interruption of | |
| paste. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks @mgmacias95 for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 15, 2024
…ythonGH-121815) (cherry picked from commit 498a94c) Co-authored-by: Marta Gómez Macías <mgmacias@google.com>
Copy link
Copy Markdown
|
GH-121826 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks, Marta! ✨ 🍰 ✨ |
Sorry, something went wrong.
ambv
pushed a commit
that referenced
this pull request
Jul 16, 2024
…GH-121815) (GH-121826) (cherry picked from commit 498a94c) Co-authored-by: Marta Gómez Macías <mgmacias@google.com>
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the behaviour when sending a KeyboardInterrupt signal to the reader. I was unable to reproduce this behaviour on unit tests so I had to test it manually. I'm attaching a GIF of the tests I made to make the review easier:
