FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-121834: Improve `complex` C-API docs by sobolevn · Pull Request #121835 · python/cpython · GitHub

/ cpython Public

gh-121834: Improve complex C-API docs - #121835

Merged
sobolevn merged 6 commits into
python:mainfrom
sobolevn:issue-121834
Jul 17, 2024
ConversationCommits (6)ChecksFiles changed
Merged

gh-121834: Improve complex C-API docs#121835
sobolevn merged 6 commits into
python:mainfrom
sobolevn:issue-121834

Conversation

sobolevn commented Jul 16, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

cc @skirpichev

I unified exception messages for NULL and -1.0 cases separatelly.

📚 Documentation preview 📚: https://cpython-previews--121835.org.readthedocs.build/

sobolevn requested a review from erlend-aasland July 16, 2024 07:06
bedevere-app Bot added docs Documentation in the Doc dir skip news labels Jul 16, 2024
bedevere-app Bot mentioned this pull request Jul 16, 2024
Closed
sobolevn added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jul 16, 2024
skirpichev approved these changes Jul 16, 2024
View reviewed changes

skirpichev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Comment thread Doc/c-api/complex.rst Outdated
sobolevn and others added 3 commits July 16, 2024 10:26
skirpichev reviewed Jul 16, 2024
View reviewed changes
Comment thread Doc/c-api/complex.rst Outdated

sobolevn commented Jul 16, 2024

Copy link
Copy Markdown
Member Author

The build failure is not related, see #121766

sobolevn commented Jul 16, 2024

Copy link
Copy Markdown
Member Author

This looks fine:

Thanks everyone!

skirpichev reviewed Jul 16, 2024
View reviewed changes
Comment thread Doc/c-api/complex.rst Outdated
encukou reviewed Jul 16, 2024
View reviewed changes
Comment thread Doc/c-api/complex.rst Outdated
Update Doc/c-api/complex.rst
fbd0858 
Co-authored-by: Petr Viktorin <encukou@gmail.com>
skirpichev reviewed Jul 16, 2024
View reviewed changes
Comment thread Doc/c-api/complex.rst
sobolevn merged commit 72dccd6 into python:main Jul 17, 2024

miss-islington-app Bot commented Jul 17, 2024

Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 17, 2024
pythongh-121834: Improve complex C-API docs (pythonGH-121835)
5b8ee99 
(cherry picked from commit 72dccd6)

Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Co-authored-by: Petr Viktorin <encukou@gmail.com>

sobolevn commented Jul 17, 2024

Copy link
Copy Markdown
Member Author

Thanks everyone!

miss-islington-app Bot commented Jul 17, 2024

Copy link
Copy Markdown

Sorry, @sobolevn, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 72dccd60735b597e99c007a7b69210763a746877 3.12

bedevere-app Bot commented Jul 17, 2024

Copy link
Copy Markdown

GH-121895 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jul 17, 2024

sobolevn commented Jul 17, 2024

Copy link
Copy Markdown
Member Author

I will backport this to 3.12 manually.

sobolevn added a commit to sobolevn/cpython that referenced this pull request Jul 17, 2024
[3.12] pythongh-121834: Improve complex C-API docs (pythonGH-121835)
e11ca8e 
(cherry picked from commit 72dccd6)

Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Co-authored-by: Petr Viktorin <encukou@gmail.com>

bedevere-app Bot commented Jul 17, 2024

Copy link
Copy Markdown

GH-121897 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jul 17, 2024
sobolevn added a commit that referenced this pull request Jul 17, 2024
[3.13] gh-121834: Improve complex C-API docs (GH-121835) (#121895)
bcf1c70 
gh-121834: Improve `complex` C-API docs (GH-121835)
(cherry picked from commit 72dccd6)

Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Co-authored-by: Petr Viktorin <encukou@gmail.com>
sobolevn added a commit that referenced this pull request Jul 17, 2024
[3.12] gh-121834: Improve complex C-API docs (GH-121835) (#121897)
6a19d22 
* [3.12] gh-121834: Improve `complex` C-API docs (GH-121835)
(cherry picked from commit 72dccd6)

Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Co-authored-by: Petr Viktorin <encukou@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

encukou encukou left review comments
skirpichev skirpichev approved these changes
erlend-aasland erlend-aasland approved these changes

Assignees

sobolevn

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL