[3.12] gh-119698: fix a special case in symtable.Class.get_methods (GH-121802) - #121910
Merged
JelleZijlstra merged 2 commits intoJul 17, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…ythonGH-121802) (cherry picked from commit 6682d91) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Copy link
Copy Markdown
Member
|
Oh: type x[genexpr = (x async for x in [])] = (x async for x in [])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
SyntaxError: invalid syntax. Maybe you meant '==' or ':=' instead of '='?Is it expected? did something change between 3.12 and 3.13 for this? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Oh yeah, I made comprehensions in annotation scopes a syntax error in 3.12, but then added support in 3.13. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
And also, the tests were using TypeVar defaults, which only exist in 3.13. I removed the tests that rely on comprehensions within annotation scopes within classes, because that was a SyntaxError in 3.12. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 6682d91)
Co-authored-by: Bénédikt Tran 10796600+picnixz@users.noreply.github.com