Repository navigation
gh-122081: fixed crash in decimal.IEEEContext() - #122082
Merged
kumaraditya303 merged 4 commits intoAug 19, 2024
Merged
kumaraditya303 merged 4 commits into
kumaraditya303 merged 4 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Now
$ ./configure CFLAGS=-DEXTRA_FUNCTIONALITY -q && make -s && \
./python -m test test_decimal
- PASS
rhettinger
removed their request for review
July 23, 2024 23:02
picnixz
self-requested a review
August 18, 2024 08:32
picnixz
reviewed
Aug 18, 2024
Comment thread
Misc/NEWS.d/next/Library/2024-07-21-10-45-24.gh-issue-122081.dNrYMq.rst
Outdated
Comment thread
Misc/NEWS.d/next/Library/2024-07-21-10-45-24.gh-issue-122081.dNrYMq.rst
Outdated
Comment thread
Modules/_decimal/_decimal.c
Outdated
skirpichev
commented
Aug 18, 2024
Comment thread
Modules/_decimal/_decimal.c
Outdated
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz
self-requested a review
August 18, 2024 09:26
picnixz
approved these changes
Aug 18, 2024
Comment thread
Misc/NEWS.d/next/Library/2024-07-21-10-45-24.gh-issue-122081.dNrYMq.rst
Outdated
kumaraditya303
approved these changes
Aug 19, 2024
Comment thread
Modules/_decimal/_decimal.c
Outdated
Comment thread
Modules/_decimal/_decimal.c
Outdated
kumaraditya303
enabled auto-merge (squash)
August 19, 2024 07:29
Copy link
Copy Markdown
|
Thanks @skirpichev for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 19, 2024
* pythongh-122081: fixed crash in decimal.IEEEContext() Now $ ./configure CFLAGS=-DEXTRA_FUNCTIONALITY -q && make -s && \ ./python -m test test_decimal - PASS * Apply suggestions from code review Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> * Update Misc/NEWS.d/next/Library/2024-07-21-10-45-24.gh-issue-122081.dNrYMq.rst * Apply suggestions from code review --------- (cherry picked from commit b9e10d1) Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Copy link
Copy Markdown
|
Sorry, @skirpichev and @kumaraditya303, I could not cleanly backport this to 3.12 due to a conflict. cherry_picker b9e10d1a0fc4d8428d4b36eb127570a832c26b6f 3.12 |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-123136 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
kumaraditya303
added a commit
that referenced
this pull request
Aug 19, 2024
…123136) gh-122081: fixed crash in decimal.IEEEContext() (GH-122082) * gh-122081: fixed crash in decimal.IEEEContext() Now $ ./configure CFLAGS=-DEXTRA_FUNCTIONALITY -q && make -s && \ ./python -m test test_decimal - PASS * Apply suggestions from code review * Update Misc/NEWS.d/next/Library/2024-07-21-10-45-24.gh-issue-122081.dNrYMq.rst * Apply suggestions from code review --------- (cherry picked from commit b9e10d1) Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Copy link
Copy Markdown
Member
Author
|
@kumaraditya303, I'll double check, but I think that 3.12 backport - not needed. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Removing backport to 3.12 per: #122081 (comment) |
Sorry, something went wrong.
jeremyhylton
pushed a commit
to jeremyhylton/cpython
that referenced
this pull request
Aug 19, 2024
* pythongh-122081: fixed crash in decimal.IEEEContext() Now $ ./configure CFLAGS=-DEXTRA_FUNCTIONALITY -q && make -s && \ ./python -m test test_decimal - PASS * Apply suggestions from code review Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> * Update Misc/NEWS.d/next/Library/2024-07-21-10-45-24.gh-issue-122081.dNrYMq.rst * Apply suggestions from code review --------- Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Kumar Aditya <kumaraditya@python.org>
blhsing
pushed a commit
to blhsing/cpython
that referenced
this pull request
Aug 22, 2024
* pythongh-122081: fixed crash in decimal.IEEEContext() Now $ ./configure CFLAGS=-DEXTRA_FUNCTIONALITY -q && make -s && \ ./python -m test test_decimal - PASS * Apply suggestions from code review Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> * Update Misc/NEWS.d/next/Library/2024-07-21-10-45-24.gh-issue-122081.dNrYMq.rst * Apply suggestions from code review --------- Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Kumar Aditya <kumaraditya@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now
$ ./configure CFLAGS=-DEXTRA_FUNCTIONALITY -q && make -s &&
./python -m test test_decimal