GH-120754: Add more tests around seek + readall - #122103
Merged
hauntsaninja merged 3 commits intoJul 24, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
In the process of speeding up readall, A number of related tests (ex. large file tests in test_zipfile) found problems with the change I was making. This adds I/O tests to specifically test these cases to help ensure they don't regress and hopefully make debugging easier. This is part of the improvements from python#121593 (comment)
picnixz
reviewed
Jul 22, 2024
Comment thread
Lib/test/test_largefile.py
Outdated
Comment thread
Lib/test/test_largefile.py
Outdated
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
hauntsaninja
approved these changes
Jul 24, 2024
hauntsaninja
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thank you!
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks @cmaloney for the PR, and @hauntsaninja for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 24, 2024
In the process of speeding up readall, A number of related tests (ex. large file tests in test_zipfile) found problems with the change I was making. This adds I/O tests to specifically test these cases to help ensure they don't regress and hopefully make debugging easier. This is part of the improvements from https://github.com/python/cpython/pull/121593GH-issuecomment-2222261986 (cherry picked from commit 9eb7341) Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com>
Copy link
Copy Markdown
|
GH-122215 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 24, 2024
In the process of speeding up readall, A number of related tests (ex. large file tests in test_zipfile) found problems with the change I was making. This adds I/O tests to specifically test these cases to help ensure they don't regress and hopefully make debugging easier. This is part of the improvements from https://github.com/python/cpython/pull/121593GH-issuecomment-2222261986 (cherry picked from commit 9eb7341) Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com>
Copy link
Copy Markdown
|
GH-122216 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
hauntsaninja
pushed a commit
that referenced
this pull request
Jul 24, 2024
…122216) GH-120754: Add more tests around seek + readall (GH-122103) In the process of speeding up readall, A number of related tests (ex. large file tests in test_zipfile) found problems with the change I was making. This adds I/O tests to specifically test these cases to help ensure they don't regress and hopefully make debugging easier. This is part of the improvements from https://github.com/python/cpython/pull/121593GH-issuecomment-2222261986 (cherry picked from commit 9eb7341) Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com>
hauntsaninja
pushed a commit
that referenced
this pull request
Jul 24, 2024
…122215) GH-120754: Add more tests around seek + readall (GH-122103) In the process of speeding up readall, A number of related tests (ex. large file tests in test_zipfile) found problems with the change I was making. This adds I/O tests to specifically test these cases to help ensure they don't regress and hopefully make debugging easier. This is part of the improvements from https://github.com/python/cpython/pull/121593GH-issuecomment-2222261986 (cherry picked from commit 9eb7341) Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com>
nohlson
pushed a commit
to nohlson/cpython
that referenced
this pull request
Jul 24, 2024
In the process of speeding up readall, A number of related tests (ex. large file tests in test_zipfile) found problems with the change I was making. This adds I/O tests to specifically test these cases to help ensure they don't regress and hopefully make debugging easier. This is part of the improvements from python#121593 (comment)
nohlson
pushed a commit
to nohlson/cpython
that referenced
this pull request
Jul 24, 2024
In the process of speeding up readall, A number of related tests (ex. large file tests in test_zipfile) found problems with the change I was making. This adds I/O tests to specifically test these cases to help ensure they don't regress and hopefully make debugging easier. This is part of the improvements from python#121593 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the process of speeding up readall, A number of related tests (ex. large file tests in test_zipfile) found problems with the change I was making. This adds I/O tests to specifically test these cases to help ensure they don't regress and hopefully make debugging easier.
This is part of the improvements from #121593 (comment)