gh-120974: Use common freelist code in asyncio - #122132
Merged
kumaraditya303 merged 1 commit intoJul 23, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This refactors asyncio to use the common freelist helper functions and macros. As a side effect, the freelist for _asyncio.Future is now re-enabled in the free-threaded build.
colesbury
requested review from
1st1,
asvetlov,
ericsnowcurrently,
gvanrossum and
willingc
as code owners
July 22, 2024 17:42
Copy link
Copy Markdown
Contributor
Author
|
!buildbot Ubuntu refleaks |
Sorry, something went wrong.
Copy link
Copy Markdown
|
The regex 'Ubuntu refleaks' did not match any buildbot builder. Is the requested builder in the list of stable builders? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
!buildbot refleaks |
Sorry, something went wrong.
Copy link
Copy Markdown
|
🤖 New build scheduled with the buildbot fleet by @colesbury for commit 21cdcd2 🤖 The command will test the builders whose names match following regular expression: refleaks The builders matched are:
|
Sorry, something went wrong.
eendebakpt
reviewed
Jul 22, 2024
Comment thread
Objects/object.c
kumaraditya303
approved these changes
Jul 23, 2024
kumaraditya303
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Fidget-Spinner
approved these changes
Jul 23, 2024
Fidget-Spinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Took a look at the new freelist code as well. This LGTM.
Sorry, something went wrong.
nohlson
pushed a commit
to nohlson/cpython
that referenced
this pull request
Jul 24, 2024
This refactors asyncio to use the common freelist helper functions and macros. As a side effect, the freelist for _asyncio.Future is now re-enabled in the free-threaded build.
nohlson
pushed a commit
to nohlson/cpython
that referenced
this pull request
Jul 24, 2024
This refactors asyncio to use the common freelist helper functions and macros. As a side effect, the freelist for _asyncio.Future is now re-enabled in the free-threaded build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors asyncio to use the common freelist helper functions and macros. As a side effect, the freelist for _asyncio.Future is now re-enabled in the free-threaded build.