gh-122163: Add notes for JSON serialization errors - #122165
Merged
serhiy-storchaka merged 1 commit intoJul 23, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This allows to identify the source of the error.
iritkatriel
approved these changes
Jul 23, 2024
iritkatriel
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
nohlson
pushed a commit
to nohlson/cpython
that referenced
this pull request
Jul 24, 2024
…2165) This allows to identify the source of the error.
nohlson
pushed a commit
to nohlson/cpython
that referenced
this pull request
Jul 24, 2024
…2165) This allows to identify the source of the error.
Copy link
Copy Markdown
Contributor
|
Serhiy, how can I do this in a third party library? _PyErr_FormatNote() is not part of the public API. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
You can do this by implementing your own _PyErr_FormatNote() or like. Create a string object and call the add_note() method of the exception. |
Sorry, something went wrong.
This was referenced Jan 3, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to identify the source of the error.
📚 Documentation preview 📚: https://cpython-previews--122165.org.readthedocs.build/