gh-117657: Avoid race in PAUSE_ADAPTIVE_COUNTER in free-threaded build - #122190
Merged
colesbury merged 2 commits intoJul 30, 2024
Merged
gh-117657: Avoid race in PAUSE_ADAPTIVE_COUNTER in free-threaded build#122190colesbury merged 2 commits into
colesbury merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…ded build The adaptive counter doesn't do anything currently in the free-threaded build and TSan reports a data race due to concurrent modifications to the counter.
Fidget-Spinner
approved these changes
Jul 24, 2024
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I was wondering why I never saw this race. Seems like it's only instrumentation that triggers it.
(Verified by looking at bytecodes.c and ceval.c)
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 30, 2024
…ded build (pythonGH-122190) The adaptive counter doesn't do anything currently in the free-threaded build and TSan reports a data race due to concurrent modifications to the counter. (cherry picked from commit 2b163aa) Co-authored-by: Sam Gross <colesbury@gmail.com>
Copy link
Copy Markdown
|
GH-122475 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
blhsing
pushed a commit
to blhsing/cpython
that referenced
this pull request
Aug 22, 2024
…ded build (python#122190) The adaptive counter doesn't do anything currently in the free-threaded build and TSan reports a data race due to concurrent modifications to the counter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The adaptive counter doesn't do anything currently in the free-threaded build and TSan reports a data race due to concurrent modifications to the counter.