FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-119180: Add evaluate functions for type params and type aliases by JelleZijlstra · Pull Request #122212 · python/cpython · GitHub

/ cpython Public

gh-119180: Add evaluate functions for type params and type aliases - #122212

Merged
JelleZijlstra merged 4 commits into
python:mainfrom
JelleZijlstra:pep649-typevar2
Jul 27, 2024
ConversationCommits (4)ChecksFiles changed
Merged

gh-119180: Add evaluate functions for type params and type aliases#122212
JelleZijlstra merged 4 commits into
python:mainfrom
JelleZijlstra:pep649-typevar2

Conversation

JelleZijlstra commented Jul 24, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Jul 24, 2024
Closed
30 tasks
carljm approved these changes Jul 26, 2024
View reviewed changes
Comment thread Objects/genericaliasobject.c Outdated

static int
ga_repr_items_list(PyUnicodeWriter *writer, PyObject *p)
ga_repr_items_list(_PyUnicodeWriter *writer, PyObject *p)

carljm Jul 26, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It looks like this change from PyUnicodeWriter * to _PyUnicodeWriter * in this signature causes a lot of compiler warnings below.

JelleZijlstra Jul 26, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks, there was a change to this API since I first wrote the code and I may not have merged properly.

JelleZijlstra added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jul 27, 2024

bedevere-bot commented Jul 27, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit 742400f 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jul 27, 2024

JelleZijlstra commented Jul 27, 2024

Copy link
Copy Markdown
Member Author

Going to merge this if the refleak buildbots are happy

JelleZijlstra enabled auto-merge (squash) July 27, 2024 16:59
JelleZijlstra disabled auto-merge July 27, 2024 16:59
JelleZijlstra enabled auto-merge (squash) July 27, 2024 16:59
JelleZijlstra merged commit ae19226 into python:main Jul 27, 2024

sobolevn commented Jul 27, 2024

Copy link
Copy Markdown
Member

I submitted #122362

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

carljm carljm approved these changes
ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
markshannon Awaiting requested review from markshannon markshannon is a code owner
iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL