gh-120974: Make asyncio swap_current_task safe in free-threaded build - #122317
Merged
kumaraditya303 merged 2 commits intoAug 2, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…ed build Use a critical section around the modifications to `current_tasks`.
colesbury
requested review from
1st1,
asvetlov,
gvanrossum,
markshannon,
methane and
willingc
as code owners
July 26, 2024 16:48
Copy link
Copy Markdown
Contributor
Author
|
!buildbot nogil refleaks |
Sorry, something went wrong.
Copy link
Copy Markdown
|
🤖 New build scheduled with the buildbot fleet by @colesbury for commit 846f6f8 🤖 The command will test the builders whose names match following regular expression: nogil refleaks The builders matched are:
|
Sorry, something went wrong.
Comment thread
Modules/_asynciomodule.c
Outdated
kumaraditya303
approved these changes
Jul 31, 2024
Copy link
Copy Markdown
|
Thanks @colesbury for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 2, 2024
…ed build (pythonGH-122317) * pythongh-120974: Make asyncio `swap_current_task` safe in free-threaded build (cherry picked from commit b5e6fb3) Co-authored-by: Sam Gross <colesbury@gmail.com>
Copy link
Copy Markdown
|
GH-122612 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot iOS ARM64 Simulator 3.13 has failed when building commit c1efeb3. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/#builders/1386/builds/461 Failed tests:
Failed subtests:
Summary of the results of the build (if available): == Click to see traceback logsTraceback (most recent call last):
File "/Users/buildbot/Library/Developer/XCTestDevices/0CD06645-FC15-4514-B5DC-AEF3ED24C912/data/Containers/Bundle/Application/1AE2CD3C-EBB6-482B-B920-80647D6C686A/iOSTestbed.app/python/lib/python3.13/test/test_httplib.py", line 1778, in testHTTPConnectionSourceAddress
self.conn.connect()
~~~~~~~~~~~~~~~~~^^
File "/Users/buildbot/Library/Developer/XCTestDevices/0CD06645-FC15-4514-B5DC-AEF3ED24C912/data/Containers/Bundle/Application/1AE2CD3C-EBB6-482B-B920-80647D6C686A/iOSTestbed.app/python/lib/python3.13/http/client.py", line 1001, in connect
self.sock = self._create_connection(
~~~~~~~~~~~~~~~~~~~~~~~^
(self.host,self.port), self.timeout, self.source_address)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/buildbot/Library/Developer/XCTestDevices/0CD06645-FC15-4514-B5DC-AEF3ED24C912/data/Containers/Bundle/Application/1AE2CD3C-EBB6-482B-B920-80647D6C686A/iOSTestbed.app/python/lib/python3.13/socket.py", line 864, in create_connection
raise exceptions[0]
File "/Users/buildbot/Library/Developer/XCTestDevices/0CD06645-FC15-4514-B5DC-AEF3ED24C912/data/Containers/Bundle/Application/1AE2CD3C-EBB6-482B-B920-80647D6C686A/iOSTestbed.app/python/lib/python3.13/socket.py", line 848, in create_connection
sock.bind(source_address)
~~~~~~~~~^^^^^^^^^^^^^^^^
OSError: [Errno 48] Address already in use
|
Sorry, something went wrong.
brandtbucher
pushed a commit
to brandtbucher/cpython
that referenced
this pull request
Aug 7, 2024
…ed build (python#122317) * pythongh-120974: Make asyncio `swap_current_task` safe in free-threaded build
blhsing
pushed a commit
to blhsing/cpython
that referenced
this pull request
Aug 22, 2024
…ed build (python#122317) * pythongh-120974: Make asyncio `swap_current_task` safe in free-threaded build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a critical section around the modifications to current_tasks so that the swapping is atomic.