FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-119180: annotationlib: Fix __all__, other minor fixes by JelleZijlstra · Pull Request #122365 · python/cpython · GitHub

/ cpython Public

gh-119180: annotationlib: Fix __all__, other minor fixes - #122365

Merged
JelleZijlstra merged 3 commits into
python:mainfrom
JelleZijlstra:pep649-cleanup
Aug 11, 2024
ConversationCommits (3)ChecksFiles changed
Merged

gh-119180: annotationlib: Fix __all__, other minor fixes#122365
JelleZijlstra merged 3 commits into
python:mainfrom
JelleZijlstra:pep649-cleanup

Conversation

JelleZijlstra commented Jul 27, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Jul 27, 2024
Closed
30 tasks
JelleZijlstra commented Jul 27, 2024
View reviewed changes
Comment thread Lib/annotationlib.py
Comment on lines +13 to +14
"call_evaluate_function",
"get_annotate_function",

JelleZijlstra Jul 27, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

These two were missing. The rest of the changes in this file are just formatting.

Comment thread Lib/test/test_annotationlib.py
self.assertIs(annotate_func, None)


class TestAnnotationLib(unittest.TestCase):

JelleZijlstra Jul 27, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is the only non-formatting change in this file.

JelleZijlstra changed the title gh-119180: annotationlib: Fix __all__, reformat, other minor fixes gh-119180: annotationlib: Fix __all__, run Black on annotationlib.py, other minor fixes Jul 27, 2024
AA-Turner reviewed Jul 27, 2024
View reviewed changes

AA-Turner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is the first stdlib module we're proposing to use autoformatting for, is it worth checking on Discourse? Autoformatters are much more opionated than PEP 8, which may be a surprising experience for contributors (note @encukou ran into an issue with a similar tool just whilst making a change to a CPython-only docs extension).

A

JelleZijlstra commented Jul 27, 2024

Copy link
Copy Markdown
Member Author

I hoped it wouldn't be controversial since we're already doing it for some of the Tools/ code. I'm not interested in discussing this issue on Discourse; if there's disagreement, I'll just take out the autoformatting.

JelleZijlstra enabled auto-merge (squash) August 11, 2024 23:21
JelleZijlstra merged commit 4534068 into python:main Aug 11, 2024
hugovk changed the title gh-119180: annotationlib: Fix __all__, run Black on annotationlib.py, other minor fixes gh-119180: annotationlib: Fix __all__, run Black other minor fixes Aug 12, 2024
hugovk changed the title gh-119180: annotationlib: Fix __all__, run Black other minor fixes gh-119180: annotationlib: Fix __all__, other minor fixes Aug 12, 2024
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
pythongh-119180: annotationlib: Fix __all__, formatting (python#122365)
ace7ab9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AA-Turner AA-Turner left review comments
AlexWaygood Awaiting requested review from AlexWaygood
hugovk Awaiting requested review from hugovk

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL