FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-122272: guarantee specifiers %F and %C for datetime.strftime to be 0-padded by blhsing · Pull Request #122436 · python/cpython · GitHub

Repository navigation

gh-122272: guarantee specifiers %F and %C for datetime.strftime to be 0-padded - #122436

Merged
serhiy-storchaka merged 11 commits into
python:mainfrom
blhsing:fix-datetime-strftime-f-c-normalization
Aug 23, 2024
Merged

serhiy-storchaka merged 11 commits into
python:mainfrom
blhsing:fix-datetime-strftime-f-c-normalization

Conversation

blhsing commented Jul 30, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

blhsing marked this pull request as ready for review July 30, 2024 06:08
blhsing requested review from abalkin and pganssle as code owners July 30, 2024 06:08
serhiy-storchaka self-requested a review July 30, 2024 10:54

Copy link
Copy Markdown
Contributor

I won't be able to review this for at least a couple of weeks.

Comment thread Lib/_pydatetime.py Outdated
Comment thread Modules/_datetimemodule.c Outdated
Comment thread Lib/_pydatetime.py Outdated
Comment thread Modules/_datetimemodule.c Outdated

blhsing commented Aug 22, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

My last push produced an error in a thread sanitizer check from code completely unrelated to mine , so I thought I'd try "fixing" the error by rebasing my branch to the latest master in hope that someone else already fixed the issue, and that resulted in the massive inclusion of all commits between the master my branch was originally based on and the latest master.

I tried to undo my rebase by force-pushing my last commit to the branch, but it still results in the code owners of all unrelated commits being tagged as reviewers for this PR by GitHub. Sorry about that.

methane commented Aug 22, 2024

Copy link
Copy Markdown
Member

This is why merge is better than rebase when updating PR.

blhsing commented Aug 22, 2024

Copy link
Copy Markdown
Contributor Author

This is why merge is better than rebase when updating PR.

Lesson learned. Thanks.

mhsmith commented Aug 22, 2024

Copy link
Copy Markdown
Member

I've restored the previous reviewers list.

Comment thread Modules/_datetimemodule.c Outdated

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

Copy link
Copy Markdown

Thanks @blhsing for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

Copy link
Copy Markdown

Thanks @blhsing for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

Copy link
Copy Markdown

Sorry, @blhsing and @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 126910edba812a01794f307b0cfa2a7f02bda190 3.12

Copy link
Copy Markdown

Sorry, @blhsing and @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 126910edba812a01794f307b0cfa2a7f02bda190 3.13

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL