bpo-36203: Check callback is callable in PyWeakref_NewRef - #12244
bpo-36203: Check callback is callable in PyWeakref_NewRef#12244tekknolagi wants to merge 0 commit into
Conversation
Sorry, something went wrong.
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
Sorry, something went wrong.
|
Huh, weird. I definitely signed it earlier. |
Sorry, something went wrong.
|
The patch needs tests. |
Sorry, something went wrong.
|
Err, what? Why did it close? |
Sorry, something went wrong.
|
Opened #26273 because I cannot reopen this one |
Sorry, something went wrong.
The documentation says that PyWeakref_NewRef should raise a
TypeError if the callback is not callable, None, or NULL, but the code
does not reflect the documentation. This PR fixes that.
This should probably be backported to whatever version of Python
changed that documentation.
https://bugs.python.org/issue36203