FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-122133: Rework pure Python socketpair tests to avoid use of importlib.reload. by freakboy3742 · Pull Request #122493 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-122133: Rework pure Python socketpair tests to avoid use of importlib.reload. - #122493

Merged
Yhg1s merged 2 commits into
python:mainfrom
freakboy3742:socket-noreload
Jul 31, 2024
ConversationCommits (2)ChecksFiles changed
Merged

gh-122133: Rework pure Python socketpair tests to avoid use of importlib.reload.#122493
Yhg1s merged 2 commits into
python:mainfrom
freakboy3742:socket-noreload

Conversation

freakboy3742 commented Jul 31, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

#122134 introduced a small change to the operation of the pure-Python socket.socketpair() method, and added a test for that method. However, the test used importlib.reload, which is problematic because there are methods that include import-time binding of symbols like _GLOBAL_DEFAULT_TIMEOUT as default arguments.

This manifested as test failures and a test lockup on iOS, but it would likely be possible to manifest similar problems on other platforms.

This PR modifies the socket module so that the pure Python fallback method is always defined, and is monkey patched into place for the pure python test, rather than performing a module reload.

Tagged for backport to all releases back to 3.8 because #122134 was back ported to all releases.

bedevere-app Bot mentioned this pull request Jul 31, 2024
Closed

freakboy3742 commented Jul 31, 2024

Copy link
Copy Markdown
Contributor Author

!buildbot iOS

bedevere-bot commented Jul 31, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 02112a0 🤖

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

  • iOS ARM64 Simulator PR

gpshead added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 31, 2024

bedevere-bot commented Jul 31, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @gpshead for commit b1b7823 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 31, 2024
Yhg1s merged commit f071f01 into python:main Jul 31, 2024

miss-islington-app Bot commented Jul 31, 2024

Copy link
Copy Markdown

Thanks @freakboy3742 for the PR, and @Yhg1s for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9, 3.10, 3.11, 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 31, 2024
pythongh-122133: Rework pure Python socketpair tests to avoid use of …
3c2d9c6 
…importlib.reload. (pythonGH-122493)

(cherry picked from commit f071f01)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 31, 2024
pythongh-122133: Rework pure Python socketpair tests to avoid use of …
3f4f577 
…importlib.reload. (pythonGH-122493)

(cherry picked from commit f071f01)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>

bedevere-app Bot commented Jul 31, 2024

Copy link
Copy Markdown

GH-122504 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jul 31, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 31, 2024
pythongh-122133: Rework pure Python socketpair tests to avoid use of …
c9e5b67 
…importlib.reload. (pythonGH-122493)

(cherry picked from commit f071f01)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>

bedevere-app Bot commented Jul 31, 2024

Copy link
Copy Markdown

GH-122505 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jul 31, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 31, 2024
pythongh-122133: Rework pure Python socketpair tests to avoid use of …
0d54900 
…importlib.reload. (pythonGH-122493)

(cherry picked from commit f071f01)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>

bedevere-app Bot commented Jul 31, 2024

Copy link
Copy Markdown

GH-122506 is a backport of this pull request to the 3.11 branch.

bedevere-app Bot removed the needs backport to 3.11 only security fixes label Jul 31, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 31, 2024
pythongh-122133: Rework pure Python socketpair tests to avoid use of …
312495b 
…importlib.reload. (pythonGH-122493)

(cherry picked from commit f071f01)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>

bedevere-app Bot commented Jul 31, 2024

Copy link
Copy Markdown

GH-122507 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 31, 2024
pythongh-122133: Rework pure Python socketpair tests to avoid use of …
6f9ff6b 
…importlib.reload. (pythonGH-122493)

(cherry picked from commit f071f01)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>

bedevere-app Bot commented Jul 31, 2024

Copy link
Copy Markdown

GH-122508 is a backport of this pull request to the 3.9 branch.

bedevere-app Bot commented Jul 31, 2024

Copy link
Copy Markdown

GH-122509 is a backport of this pull request to the 3.8 branch.

Yhg1s pushed a commit that referenced this pull request Jul 31, 2024
[3.13] gh-122133: Rework pure Python socketpair tests to avoid use of…
c21a361 
… importlib.reload. (GH-122493) (#122504)

gh-122133: Rework pure Python socketpair tests to avoid use of importlib.reload. (GH-122493)

(cherry picked from commit f071f01)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
mhsmith mentioned this pull request Jul 31, 2024
Merged
gpshead added a commit that referenced this pull request Jul 31, 2024
[3.12] gh-122133: Rework pure Python socketpair tests to avoid use of…
5df322e 
… importlib.reload. (GH-122493) (GH-122505)

gh-122133: Rework pure Python socketpair tests to avoid use of importlib.reload. (GH-122493)

(cherry picked from commit f071f01)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
freakboy3742 deleted the socket-noreload branch July 31, 2024 21:41
ambv pushed a commit that referenced this pull request Aug 2, 2024
[3.11] gh-122133: Rework pure Python socketpair tests to avoid use of…
c5655aa 
… importlib.reload. (GH-122493) (GH-122506)

(cherry picked from commit f071f01)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
ambv pushed a commit that referenced this pull request Aug 2, 2024
[3.10] gh-122133: Rework pure Python socketpair tests to avoid use of…
31302f5 
… importlib.reload. (GH-122493) (GH-122507)

(cherry picked from commit f071f01)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
ambv pushed a commit that referenced this pull request Aug 2, 2024
[3.9] gh-122133: Rework pure Python socketpair tests to avoid use of …
3f5d9d1 
…importlib.reload. (GH-122493) (GH-122508)

(cherry picked from commit f071f01)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
ambv pushed a commit that referenced this pull request Aug 2, 2024
[3.8] gh-122133: Rework pure Python socketpair tests to avoid use of …
e319f77 
…importlib.reload. (GH-122493) (GH-122509)

(cherry picked from commit f071f01)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
pythongh-122133: Rework pure Python socketpair tests to avoid use of …
23ed3cf 
…importlib.reload. (python#122493)


Co-authored-by: Gregory P. Smith <greg@krypto.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gpshead gpshead approved these changes
sethmlarson Awaiting requested review from sethmlarson

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL