FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-122549: Allow to invalidate platform's cached results by picnixz · Pull Request #122547 · python/cpython · GitHub

/ cpython Public

gh-122549: Allow to invalidate platform's cached results - #122547

Merged
vstinner merged 9 commits into
python:mainfrom
picnixz:platform-invalidate-cache
Nov 15, 2024
ConversationCommits (9)ChecksFiles changed
Merged

gh-122549: Allow to invalidate platform's cached results#122547
vstinner merged 9 commits into
python:mainfrom
picnixz:platform-invalidate-cache

Conversation

picnixz commented Aug 1, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Using a cache invalidation approach is probably better than querying the new results every time. At least, it will not cause any breaking change.

📚 Documentation preview 📚: https://cpython-previews--122547.org.readthedocs.build/

bedevere-app Bot mentioned this pull request Aug 1, 2024
Closed
picnixz changed the title gh-122525: Allow to invalidate platform's cached results gh-122549: Allow to invalidate platform's cached results Aug 1, 2024
bedevere-app Bot mentioned this pull request Aug 1, 2024
Closed
kashav suggested changes Aug 1, 2024
View reviewed changes

kashav left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The current implementation doesn’t seem useful to me.

Comment thread Lib/platform.py
ZeroIntensity reviewed Aug 1, 2024
View reviewed changes
Comment thread Lib/platform.py Outdated
vstinner approved these changes Aug 9, 2024
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. The function looks useful when the hostname changes, tests look complete, and the documentation is good enough.

Comment thread Lib/platform.py
picnixz added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 26, 2024

bedevere-bot commented Aug 26, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @picnixz for commit 42668a3 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 26, 2024

picnixz commented Aug 26, 2024

Copy link
Copy Markdown
Member Author

I just want to be sure that build bots won't be unhappy with this change for whatever reason (we'll get the answer in roughly 8 hours)

picnixz commented Aug 26, 2024

Copy link
Copy Markdown
Member Author

The USAN failures are known #111178, the refleaks on Fedora are known as well #122136.

vstinner enabled auto-merge (squash) November 15, 2024 13:42
vstinner merged commit 612ac28 into python:main Nov 15, 2024
picnixz deleted the platform-invalidate-cache branch November 15, 2024 13:55
picnixz commented Nov 16, 2024
View reviewed changes
Comment thread Doc/library/platform.rst
This is typically useful when the platform's :func:`node` is changed
by an external process and one needs to retrieve the updated value.

.. versionadded:: 3.14

picnixz Nov 16, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I should have used a versionadded:: next here but at that time, it didn't exist yet. Not sure if this warrants an additional commit though. WDYT @vstinner

vstinner Nov 18, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

next will be replaced with 3.14 anyway, there is no need to replace it.

picnixz Nov 18, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yea but sometimes users are confused that the feature is present in the docs but not in the current release. That was the purpose of next

picnixz added a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
pythongh-122549: Add platform.invalidate_caches() (python#122547)
4330cad 
Allow to invalidate platform's cached results.
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
pythongh-122549: Add platform.invalidate_caches() (python#122547)
2b73db0 
Allow to invalidate platform's cached results.
hugovk mentioned this pull request Jan 25, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes
ZeroIntensity ZeroIntensity left review comments
+1 more reviewer
kashav kashav requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL