[3.12] gh-121650: Encode newlines in headers, and verify headers are sound (GH-122233) - #122599
Merged
Yhg1s merged 2 commits intoAug 6, 2024
Merged
[3.12] gh-121650: Encode newlines in headers, and verify headers are sound (GH-122233)#122599Yhg1s merged 2 commits into
Yhg1s merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…ound (pythonGH-122233) - Encode header parts that contain newlines Per RFC 2047: > [...] these encoding schemes allow the > encoding of arbitrary octet values, mail readers that implement this > decoding should also ensure that display of the decoded data on the > recipient's terminal will not cause unwanted side-effects It seems that the "quoted-word" scheme is a valid way to include a newline character in a header value, just like we already allow undecodable bytes or control characters. They do need to be properly quoted when serialized to text, though. - Verify that email headers are well-formed This should fail for custom fold() implementations that aren't careful about newlines. Co-authored-by: Bas Bloemsaat <bas@bloemsaat.org> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> (cherry picked from commit 0976339)
This was referenced Aug 2, 2024
Copy link
Copy Markdown
Member
Author
|
Marking this for consideration as a release blocker. |
Sorry, something went wrong.
smoser
added a commit
to smoser/advisories
that referenced
this pull request
Aug 8, 2024
The fix for this issue was included in upstream release of 3.12.5. python/cpython#122599
github-merge-queue Bot
pushed a commit
to wolfi-dev/advisories
that referenced
this pull request
Aug 8, 2024
The fix for this issue was included in upstream release of 3.12.5. python/cpython#122599
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per RFC 2047:
It seems that the "quoted-word" scheme is a valid way to include
a newline character in a header value, just like we already allow
undecodable bytes or control characters.
They do need to be properly quoted when serialized to text, though.
This should fail for custom fold() implementations that aren't careful
about newlines.
Co-authored-by: Bas Bloemsaat bas@bloemsaat.org
Co-authored-by: Serhiy Storchaka storchaka@gmail.com
(cherry picked from commit 0976339)
📚 Documentation preview 📚: https://cpython-previews--122599.org.readthedocs.build/