[3.8] gh-121650: Encode newlines in headers, and verify headers are sound (GH-122233) - #122611
Merged
ambv merged 4 commits intoSep 4, 2024
Merged
[3.8] gh-121650: Encode newlines in headers, and verify headers are sound (GH-122233)#122611ambv merged 4 commits into
ambv merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
… are sound (pythonGH-122233) Per RFC 2047: > [...] these encoding schemes allow the > encoding of arbitrary octet values, mail readers that implement this > decoding should also ensure that display of the decoded data on the > recipient's terminal will not cause unwanted side-effects It seems that the "quoted-word" scheme is a valid way to include a newline character in a header value, just like we already allow undecodable bytes or control characters. They do need to be properly quoted when serialized to text, though. This should fail for custom fold() implementations that aren't careful about newlines. (cherry picked from commit 0976339) Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Bas Bloemsaat <bas@bloemsaat.org> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
This was referenced Aug 2, 2024
Copy link
Copy Markdown
Member
|
Sadly, the build fails on macOS: checking for gcc... clang checking whether the C compiler works... no configure: error: in `/Users/runner/work/cpython/cpython': configure: error: C compiler cannot create executables See `config.log' for more details |
Sorry, something went wrong.
vstinner
approved these changes
Sep 2, 2024
vstinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM: straightforward backport and the change is properly documented as .. versionadded:: 3.8.20 with "Notable changes in 3.8.20" in What's New in Python 3.8. I compared this 3.8 change to the change in the main branch.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per RFC 2047:
It seems that the "quoted-word" scheme is a valid way to include a newline character in a header value, just like we already allow undecodable bytes or control characters.
They do need to be properly quoted when serialized to text, though.
This should fail for custom fold() implementations that aren't careful about newlines.
(cherry picked from commit 0976339)