| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Sorry, something went wrong.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead. |
Sorry, something went wrong.
…4QdB2.rst Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
There was a problem hiding this comment.
As you note, the audio/ versions already exist:
Lines 527 to 530 in efcd65c
The suffixes are the same, though, so this would overwrite as they appear later in the dict. Can you think of a way to fix that?
A
Sorry, something went wrong.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request. |
Sorry, something went wrong.
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
|
@AA-Turner I have made the requested changes; please review again. I think ideally types_map would also be a dict[str, list[str]] like types_map_inv is, so that every extension would map to a list of types. But that would be a pretty big breaking change for my first PR here (since types_map gets exported), lemme know if you think I should tackle that instead of my more band-aid solution here. (Also I'm not sure what's going on with my NEWS build errors, would appreciate any pointers there.) EDIT: I put up a PR on my fork of how I would do the breaking version. I do think it's cleaner, and more future-proof, but obviously it's a breaking change on types_map and presumably we'd have to go through channels for that. Lemme know your thoughts. robotmlg#1 |
Sorry, something went wrong.
|
Thanks for making the requested changes! @AA-Turner: please review the changes made to this pull request. |
Sorry, something went wrong.
|
This PR is stale because it has been open for 30 days with no activity. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
These are officially recognized by IANA