FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-122686: pin attrs package (for hypothesis workflow) by skirpichev · Pull Request #122687 · python/cpython · GitHub

/ cpython Public

gh-122686: pin attrs package (for hypothesis workflow) - #122687

Merged
hugovk merged 3 commits into
python:mainfrom
skirpichev:pin-attrs-122686
Aug 6, 2024
Merged

gh-122686: pin attrs package (for hypothesis workflow)#122687
hugovk merged 3 commits into
python:mainfrom
skirpichev:pin-attrs-122686

Conversation

skirpichev commented Aug 5, 2024
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

hugovk commented Aug 5, 2024

Copy link
Copy Markdown
Member

Do we still need to pin if upgrading to latest hypothesis==6.108.8?

If so, please can you add a comment as to why we're adding an attrs pin?

Copy link
Copy Markdown
Member Author

Do we still need to pin if upgrading to latest hypothesis==6.108.8?

Yes, I think so. See:
https://github.com/python/cpython/actions/runs/10246311678/job/28343157458

If so, please can you add a comment as to why we're adding an attrs pin?

I did no debugging, but new release seems broken on the CPython main. Pinning "just works", e.g. (see last commit):
#122682

I'll open issue for attrs and add a comment with reference.

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Comment thread Tools/requirements-hypothesis.txt Outdated
Co-authored-by: Victor Stinner <vstinner@python.org>
hugovk merged commit 35ae4aa into python:main Aug 6, 2024
skirpichev deleted the pin-attrs-122686 branch August 6, 2024 03:58

hugovk commented Aug 6, 2024

Copy link
Copy Markdown
Member

Thanks!

brandtbucher pushed a commit to brandtbucher/cpython that referenced this pull request Aug 7, 2024
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL