FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-122681: remove m_atan2()/c_atan2() helpers by skirpichev · Pull Request #122715 · python/cpython · GitHub

/ cpython Public

gh-122681: remove m_atan2()/c_atan2() helpers - #122715

Merged
kumaraditya303 merged 3 commits into
python:mainfrom
skirpichev:remove-atan2-helpers-122681
Aug 17, 2024
Merged

gh-122681: remove m_atan2()/c_atan2() helpers#122715
kumaraditya303 merged 3 commits into
python:mainfrom
skirpichev:remove-atan2-helpers-122681

Conversation

skirpichev commented Aug 6, 2024
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

This comment was marked as outdated.

vstinner commented Aug 6, 2024

Copy link
Copy Markdown
Member

Can you rebase/merge your branch to avoid the merge conflict? Then I can run buildbots on this PR.

skirpichev marked this pull request as ready for review August 6, 2024 12:52

This comment was marked as outdated.

vstinner added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 6, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @vstinner for commit a4aff45 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 6, 2024

Copy link
Copy Markdown
Member Author

No failures, related to this pr.

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

@skirpichev: Did you just create to see if removing the wrapper would work or not, or do you propose to remove it?

Copy link
Copy Markdown
Member Author

Yeah, I think we can remove it; testing with buildbots - for additional safety. But it's not urgent and I would appreciate @mdickinson blessing.

Current workarounds fix only few functions in cmath. Missing bugreports - another indication, that underlying problems were fixed on affected systems.

kumaraditya303 added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 17, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 11a6f3d 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 17, 2024
kumaraditya303 merged commit 19be0ee into python:main Aug 17, 2024
skirpichev deleted the remove-atan2-helpers-122681 branch August 17, 2024 08:26
jeremyhylton pushed a commit to jeremyhylton/cpython that referenced this pull request Aug 19, 2024
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL