gh-121268: remove workarounds for non-IEEE 754 systems in cmath - #122716
Merged
vstinner merged 2 commits intoAug 9, 2024
Merged
gh-121268: remove workarounds for non-IEEE 754 systems in cmath#122716vstinner merged 2 commits into
vstinner merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
as now building Python now requires support of IEEE 754 floating point numbers.
vstinner
approved these changes
Aug 8, 2024
vstinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM if buildbots are happy with this change.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
No failures, related to this pr. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Merged, thanks. |
Sorry, something went wrong.
Copy link
Copy Markdown
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot iOS ARM64 Simulator 3.x has failed when building commit b6e745a. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/#builders/1380/builds/1044 Failed tests:
Failed subtests:
Summary of the results of the build (if available): == Click to see traceback logsTraceback (most recent call last):
File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/test/test_socketserver.py", line 222, in test_UnixDatagramServer
self.run_server(socketserver.UnixDatagramServer,
~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
socketserver.DatagramRequestHandler,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
self.dgram_examine)
^^^^^^^^^^^^^^^^^^^
File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/test/support/threading_helper.py", line 66, in decorator
return func(*args)
File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/test/test_socketserver.py", line 133, in run_server
testfunc(svrcls.address_family, addr)
~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/test/test_socketserver.py", line 160, in dgram_examine
buf = data = receive(s, 100)
~~~~~~~^^^^^^^^
File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/test/test_socketserver.py", line 43, in receive
raise RuntimeError("timed out on %r" % (sock,))
RuntimeError: timed out on <socket.socket fd=34, family=1, type=2, proto=0, laddr=./test_python_7aihzq4p.sock>
Traceback (most recent call last):
File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/threading.py", line 1041, in _bootstrap_inner
self.run()
~~~~~~~~^^
File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/threading.py", line 992, in run
self._target(*self._args, **self._kwargs)
~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/socketserver.py", line 240, in serve_forever
self._handle_request_noblock()
~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/socketserver.py", line 320, in _handle_request_noblock
self.handle_error(request, client_address)
~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/socketserver.py", line 318, in _handle_request_noblock
self.process_request(request, client_address)
~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/socketserver.py", line 349, in process_request
self.finish_request(request, client_address)
~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/socketserver.py", line 362, in finish_request
self.RequestHandlerClass(request, client_address, self)
~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/socketserver.py", line 763, in __init__
self.finish()
~~~~~~~~~~~^^
File "/Users/buildbot/Library/Developer/XCTestDevices/308B4A23-E523-4924-9000-9F41F1B67884/data/Containers/Bundle/Application/3D26E792-C5B1-443D-B867-3B732664079A/iOSTestbed.app/python/lib/python3.14/socketserver.py", line 858, in finish
self.socket.sendto(self.wfile.getvalue(), self.client_address)
~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ConnectionResetError: [Errno 54] Connection reset by peer
ERROR
|
Sorry, something went wrong.
blhsing
pushed a commit
to blhsing/cpython
that referenced
this pull request
Aug 22, 2024
…python#122716) As now building Python now requires support of IEEE 754 floating point numbers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as now building Python now requires support of IEEE 754 floating point numbers.