gh-118761: Improve import time of pprint - #122725
Merged
hugovk merged 5 commits intoAug 7, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
By the way, what's the reason for importing with underscores? import collections as _collections
import sys as _sys
import types as _types
from io import StringIO as _StringIO |
Sorry, something went wrong.
AA-Turner
approved these changes
Aug 7, 2024
AA-Turner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks fine -- I wouldn't change the whitespace personally but up to you.
collections you could do by hardcoding the repr and adding a test that they're the same? I agree probably not worth it, though.
A
Sorry, something went wrong.
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
blhsing
pushed a commit
to blhsing/cpython
that referenced
this pull request
Aug 22, 2024
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves import time by up to seven times. Measured with a PGO and LTO non-debug build on macOS.
The slowest import in pprint is dataclasses (taking 0.0012s / 55.2% of import time), and used in only two functions.
After deferring dataclasses, the next is re (0.005s / 30.1% of the new import time), only used in one function.
After deferring re, the next are collections (0.002s / 14.8%) and types (0.000s / 2.4%). I left these, as their times are low and they're less straightforward to defer.
-X importtime
Running: pip install tuna && ./python.exe -X importtime -c 'import pprint' 2> import.log && tuna import.log
total import time: 0.022s -> 0.011s = x2 as fast
pprint import time: 0.014s -> 0.002s = x7 as fast
hyperfine: 19.2 ms -> 10.4 ms = x1.8 as fast
main
PR
Also add some PEP 8 whitespace to remove some distracting IDE warnings.