[3.13] gh-122478: Remove internal frames from tracebacks in REPL (GH-122528) - #122817
Closed
miss-islington wants to merge 1 commit into
Closed
[3.13] gh-122478: Remove internal frames from tracebacks in REPL (GH-122528)#122817miss-islington wants to merge 1 commit into
miss-islington wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…onGH-122528) Frames of methods in code and codeop modules was show with non-default sys.excepthook. Save correct tracebacks in sys.last_traceback and update __traceback__ attribute of sys.last_value and sys.last_exc. (cherry picked from commit e73e7a7) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
This was referenced Aug 8, 2024
iritkatriel
reviewed
Aug 13, 2024
Comment thread
Lib/code.py
| # over self.write | ||
| self._call_excepthook(type, value, tb) | ||
| try: | ||
| typ, value, tb = sys.exc_info() |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
These days we do exc = sys.exception() and then use exc.__traceback__ and type(exc).
Sorry, something went wrong.
iritkatriel
approved these changes
Aug 13, 2024
cfbolz
approved these changes
Aug 13, 2024
cfbolz
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good to me
Sorry, something went wrong.
This was referenced Aug 22, 2024
Copy link
Copy Markdown
Contributor
|
backport happened in #123227 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frames of methods in code and codeop modules was show with non-default
sys.excepthook.
Save correct tracebacks in sys.last_traceback and update traceback
attribute of sys.last_value and sys.last_exc.
(cherry picked from commit e73e7a7)
Co-authored-by: Serhiy Storchaka storchaka@gmail.com