| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
…ple in the filename This permits stable ABI extensions for multiple architectures to be co-installed into the same directory, without clashing with each other, the same way (non-stable ABI) regular extensions can. It is listed below the current .abi3 suffix because setuptools will select the first suffix containing .abi3, as the target filename. We do this to protect older Python versions predating this patch.
…ple in the filename This permits stable ABI extensions for multiple architectures to be co-installed into the same directory, without clashing with each other, the same way (non-stable ABI) regular extensions can. It is listed below the current .abi3 suffix because setuptools will select the first suffix containing .abi3, as the target filename. We do this to protect older Python versions predating this patch.
There was a problem hiding this comment.
You should document this change in https://docs.python.org/dev/whatsnew/3.14.html (Doc/whatsnew/3.14.rst). I expect that you would elaborate a bit on the usage, how to use the feature, why it's needed, etc.
Sorry, something went wrong.
Done. FWIW, in Debian we plan to backport this to 3.13 too. |
Sorry, something went wrong.
|
I'm only aware of Debian who uses "multiarch". Do other operating systems also use it? Maybe Debian variants, Ubuntu, and Ubuntu variants? This change will slow down any "import module". I don't recall if there is a cache for that or not. |
Sorry, something went wrong.
All Debian derivatives, yes. They typically don't deviate very much, when it comes to plumbing. |
Sorry, something went wrong.
What do you want to do about that? Is there a benchmark you'd like to see results for? I see a table of 5 entries (including NULL) increasing to 6. That is one extra item to search, when:
|
Sorry, something went wrong.
Example of command: strace -o trace python3 -c pass strace output: newfstatat(AT_FDCWD, "/usr/lib64/python3.12/encodings/__init__.cpython-312-x86_64-linux-gnu.so", 0x7ffe20002e50, 0) = -1 ENOENT (No such file or directory)
newfstatat(AT_FDCWD, "/usr/lib64/python3.12/encodings/__init__.abi3.so", 0x7ffe20002e50, 0) = -1 ENOENT (No such file or directory)
newfstatat(AT_FDCWD, "/usr/lib64/python3.12/encodings/__init__.so", 0x7ffe20002e50, 0) = -1 ENOENT (No such file or directory)
newfstatat(AT_FDCWD, "/usr/lib64/python3.12/encodings/__init__.py", {st_mode=S_IFREG|0644, st_size=5884, ...}, 0) = 0
newfstatat(AT_FDCWD, "/usr/lib64/python3.12/encodings/__init__.py", {st_mode=S_IFREG|0644, st_size=5884, ...}, 0) = 0
openat(AT_FDCWD, "/usr/lib64/python3.12/encodings/__pycache__/__init__.cpython-312.pyc", O_RDONLY|O_CLOEXEC) = 3
Internally, when Python imports the encoding package, it has to do 4 fstat() calls. You can see a check on the .abi3.so suffix. If we add a new entry to the import suffix, it will add one fstat() syscall per import (at least, to import a package). We should consider the impact on performance if we decide to add this feature. |
Sorry, something went wrong.
FWIW: macOS, iOS and Android all use multiarch as a configuration value - it's used to differentiate ARM from x86_64 simulators, and devices from simulators/emulators. However, on iOS and Android, there's limited need to keep binary artefacts in the same folder, as any given executable can only have a single architecture's executables. In addition, in the case of iOS, the binaries need to be migrated to the Frameworks folder and named as Frameworks, so any "side-by-side" benefits would be lost. Any "other platform" executables need to be stripped out as part of the build process, at which point there's no naming conflict. macOS uses the multiarch config value, but the value is always "darwin", and the universal binary format exists to support multiple architectures in a single binary file. I guess it might be useful to be able to have x86_64 and ARM64 binaries side-by-side... but there's probably only a year or two left in the official supported life of x86_64, so I don't think adding this feature will ultimately be that helpful for the macOS use case. |
Sorry, something went wrong.
|
@stefanor: Did you consider to maintain this change as a downstream-only patch in Debian? If you would like to make it upstream, I would suggest making it optional, disabled by default, and add a configure option to enable it. That's how I added some Fedora specific changes, such as: |
Sorry, something went wrong.
|
Here are some benchmarks: There is no discernable performance difference in minimal interpreter startup python -c ''. import time
import sys
from subprocess import check_call
t1 = time.perf_counter()
for i in range(1000):
check_call([sys.executable, "-c", ""])
t2 = time.perf_counter()
print((t2-t1) / 1000)Looking at strace, I see only a single extra syscall. We can manufacture an import-intensive benchmark: import pkgutil
import time
t1 = time.perf_counter()
for module in pkgutil.walk_packages(onerror=lambda pkg: None):
if module.name.startswith("test."):
continue
if module.name.endswith(".__main__"):
continue
if module.name in {"antigravity", "idlelib.idle", "this", "zen"}:
continue
try:
__import__(module)
except Exception:
pass
t2 = time.perf_counter()
print((t2 - t1))Analysing this, I see 116 stat syscalls on .so filenames jumping to 232. But in a 100ms total execution time, that's negligible, and I can't see any statistically significant results. |
Sorry, something went wrong.
Also, note that this is used on all linux platforms. The default for (non-stable ABI) extensions is to include the multiarch tuple in the extension filename. Pick a random binary wheel built in manylinux, and you'll see them.
I would be happy to do that. Although I prefer not carrying downstream-only patches long-term if possible. Look at the mess around dist-packages for example. Without this MR, there's no real point in supporting the multiarch tags in the non-stable ABI extensions. Either we get the benefit from doing it everywhere, or you say you don't need to support the feature, and we rip it out everywhere. We've got half a feature at the moment. Would you prefer it to all be behind a config argument?
These are not entirely Fedora-specific. And that's a good argument for always trying to upstream.
In Debian we use those paths for our cross-compilers. I imagine there is a scenario where it's useful to have Python headers in there.
We're a happy customer of this too, It meant one less patch to carry. |
Sorry, something went wrong.
Maybe 0.5% slowdown with PGO. For 1 extra syscall, I'm surprised it's visible. This may still not be significant. |
Sorry, something went wrong.
|
@erlend-aasland @encukou: Would you mind to have a look at this issue? What do you think? Should it become the default behavior, or should it be a configure option? |
Sorry, something went wrong.
|
IMO, the most important thing here is to keep this in mind for abi4 (or whatever we name the free-threading-compatible stable ABI). There it should be the only option. |
Sorry, something went wrong.
Yeah, that sounds sensible.
Is that expected? We've been on abi3 for quite a while. |
Sorry, something went wrong.
If we want that for the stable ABI, do we want to do the same thing for the regular ABI? It would probably affect a lot of build systems that assume they can name their output extension.so |
Sorry, something went wrong.
Yes, over a decade. abi3 showing its age, and since it's incompatible free-threading we'll need a new alternative soon.
I don't see much reason to deprecate and remove that, so that we don't break the build systems you mention. (Note that even abi3/abi4 extensions will work with a bare .so extension, since the stable ABI is a subset of the full one.) |
Sorry, something went wrong.
I'm going to include it in our 3.13.0 upload. |
Sorry, something went wrong.
|
🔔 (I'd like to remind people to please consider this) |
Sorry, something went wrong.
Again, that's why I think that a discussion on discuss.python.org would be better (to coordinate). Maybe in the Packaging category. |
Sorry, something went wrong.
Sorry, something went wrong.
…uple in the filename This permits `abi3` stable ABI extensions for multiple architectures to be co-installed into the same directory, without clashing with each other, the same way (non-stable ABI) regular extensions can. It is listed before the current .abi3 suffix because .abi3 extensions are only compatible with future Python releases, not older versions. This follows on from python#122917 which was reduced down to just targetting `abi3t`
|
Now that this PR is just renaming abi3t there is a follow-on commit in #152461 that adds tags to abi3 (the original aim of this PR) |
Sorry, something went wrong.
…ple in the filename This permits stable ABI extensions for multiple architectures to be co-installed into the same directory, without clashing with each other, the same way (non-stable ABI) regular extensions can. It is listed below the current .abi3 suffix because setuptools will select the first suffix containing .abi3, as the target filename. We do this to protect older Python versions predating this patch.
…ple in the filename This permits stable ABI extensions for multiple architectures to be co-installed into the same directory, without clashing with each other, the same way (non-stable ABI) regular extensions can. It is listed below the current .abi3 suffix because setuptools will select the first suffix containing .abi3, as the target filename. We do this to protect older Python versions predating this patch.
|
Updated to reflect the SC request for both .abi3t.so and .abi3t-TAG.so |
Sorry, something went wrong.
| @@ -0,0 +1 @@ | |||
| Linux: Include multiarch tuples in ``abi3t`` stable ABI C extension filenames, e.g. ``foo.abi3t-x86-64-linux-gnu.so``, by default. | |||
There was a problem hiding this comment.
"Linux: ": this change doesn't seem to be specific to Linux, is it?
Sorry, something went wrong.
There was a problem hiding this comment.
Those tags won't exist on not-Linux
Sorry, something went wrong.
There was a problem hiding this comment.
Maybe we should change the text to say on platforms with multiarch tags (e.g. Linux).
Sorry, something went wrong.
There was a problem hiding this comment.
The current implementation doesn't work properly on FreeBSD, because the SOABI_PLATFORM macro is defined but it's defined to an empty string.
$ grep SOABI_PLATFORM pyconfig.h #define SOABI_PLATFORM ""
In Python:
>>> import importlib.machinery
>>> importlib.machinery.EXTENSION_SUFFIXES
['.cpython-316d.so', '.cpython-316.so', '.abi3.so', '.abi3t-.so', '.abi3t.so', '.so']
>>> import sysconfig
>>> SOABI_PLATFORM = sysconfig.get_config_var("SOABI_PLATFORM")
>>> SOABI_PLATFORM
''Notice that '.abi3t-.so' is present in EXTENSION_SUFFIXES.
Possible fix:
diff --git a/configure.ac b/configure.ac
index 2d6672e3231..c30d98af28a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1212,7 +1212,9 @@ AS_CASE([$ac_sys_system],
[SOABI_PLATFORM=$PLATFORM_TRIPLET]
)
-AC_DEFINE_UNQUOTED([SOABI_PLATFORM], ["${SOABI_PLATFORM}"], [Platform tag, used in binary module extension filenames.])
+if test x$SOABI_PLATFORM != x; then
+ AC_DEFINE_UNQUOTED([SOABI_PLATFORM], ["${SOABI_PLATFORM}"], [Platform tag, used in binary module extension filenames.])
+fi
if test x$MULTIARCH != x; then
MULTIARCH_CPPFLAGS="-DMULTIARCH=\\\"$MULTIARCH\\\""
Sorry, something went wrong.
Add ALT_SOABI and SOABI_PLATFORM to test.pythoninfo. Add also EXTENSION_SUFFIXES of importlib.machinery.
|
I pushed a change in your branch to log ALT_SOABI, SOABI_PLATFORM and EXTENSION_SUFFIXES in test.pythoninfo. |
Sorry, something went wrong.
|
For example, I looked at the WASI job. Extracts of test.pythoninfo on WASI: importlib.extension_suffixes: ['.cpython-316d-wasm32-wasi.so', '.cpython-316-wasm32-wasi.so', '.abi3.so', '.abi3t-wasm32-wasi.so', '.abi3t.so', '.so'] sysconfig[ABIFLAGS]: d sysconfig[ALT_SOABI]: cpython-316-wasm32-wasi sysconfig[SOABI]: cpython-316d-wasm32-wasi sysconfig[SOABI_PLATFORM]: wasm32-wasi
This changes adds '.abi3t-wasm32-wasi.so' to EXTENSION_SUFFIXES on WASI. Is it deliberate? |
Sorry, something went wrong.
|
pythoninfo on macOS: importlib.extension_suffixes: ['.cpython-316d-darwin.so', '.cpython-316-darwin.so', '.abi3.so', '.abi3t-darwin.so', '.abi3t.so', '.so'] sysconfig[SOABI_PLATFORM]: darwin The PR adds .abi3t-darwin.so suffix. pythoninfo on iOS: importlib.extension_suffixes: ['.cpython-316-iphonesimulator.so', '.abi3.so', '.abi3t-iphonesimulator.so', '.abi3t.so', '.so'] The PR adds .abi3t-iphonesimulator.so suffix. |
Sorry, something went wrong.
|
Thanks for checking that Victor
Agreed that that's not what we want.
I don't know much about the WASI stack, but that's probably a reasonable thing to do if one is likely to have WASI builds near native builds. I'll add your configure change, it seems reasonable. |
Sorry, something went wrong.
|
FWIW, it looks like #152461 (which was originally stacked on top of this) may merge, including these changes and more. |
Sorry, something went wrong.
|
Closing in favour of #152461 -- there's no need to merge the additions in two steps. |
Sorry, something went wrong.
|
Thank you for bringing that together! |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This permits abi3t stable ABI extensions for multiple architectures to be co-installed into the same directory, without clashing with each other, the same way (non-stable ABI) regular extensions can.