FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-122390: Replace `_Py_GetbaseOpcode` with `_Py_GetBaseCodeUnit` by markshannon · Pull Request #122942 · python/cpython · GitHub

/ cpython Public

GH-122390: Replace _Py_GetbaseOpcode with _Py_GetBaseCodeUnit - #122942

Merged
markshannon merged 5 commits into
python:mainfrom
faster-cpython:get-base-instruction
Aug 13, 2024
Merged

GH-122390: Replace _Py_GetbaseOpcode with _Py_GetBaseCodeUnit#122942
markshannon merged 5 commits into
python:mainfrom
faster-cpython:get-base-instruction

Conversation

markshannon commented Aug 12, 2024
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

This PR:

  • Ensures we account for ENTER_EXECUTOR and instrumentation whenever we need to fetch the underlying instruction.
  • Moves ENTER_EXECUTOR to opcode 255, to keep the common path fast in _Py_GetBaseCodeUnit.
  • Does a bit of tidying up around calls to _Py_GetBaseCodeUnit as we don't need the additional checks any more.

Comment thread Objects/codeobject.c Outdated

Copy link
Copy Markdown
Member Author

Failures on emulated JIT builds are a known issue.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL