GH-118093: Turn some DEOPT_IFs into EXIT_IFs - #122998
Merged
brandtbucher merged 2 commits intoAug 14, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
3 tasks
markshannon
approved these changes
Aug 14, 2024
Copy link
Copy Markdown
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot AMD64 Ubuntu NoGIL Refleaks 3.x has failed when building commit f84754b. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/#builders/1226/builds/2473 Failed tests:
Summary of the results of the build (if available): == Click to see traceback logsNote: switching to 'f84754b70506f03bcbf9fb0265e327d05a1a4b51'.
You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.
If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:
git switch -c <new-branch-name>
Or undo this operation with:
git switch -
Turn off this advice by setting config variable advice.detachedHead to false
HEAD is now at f84754b705 GH-118093: Turn some DEOPT_IFs into EXIT_IFs (GH-122998)
Switched to and reset branch 'main'
configure: WARNING: no system libmpdecimal found; falling back to bundled libmpdecimal (deprecated and scheduled for removal in Python 3.15)
make: *** [Makefile:2304: buildbottest] Error 2 |
Sorry, something went wrong.
blhsing
pushed a commit
to blhsing/cpython
that referenced
this pull request
Aug 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to stitch new traces onto these side-exits, giving us better handling of polymorphism for attribute loads and calls.
About 1% faster. Stats show a notable (~28%) drop in _DEOPT instructions and moderate increases in call and attribute load uops, as expected.