GH-118093: Specialize CALL_KW - #123006
Merged
markshannon merged 12 commits intoAug 16, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
3 tasks
Copy link
Copy Markdown
Member
Author
|
No impact on performance |
Sorry, something went wrong.
Fidget-Spinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks good in general. Two questions.
Sorry, something went wrong.
Fidget-Spinner
approved these changes
Aug 16, 2024
iritkatriel
approved these changes
Aug 16, 2024
Comment thread
Include/internal/pycore_code.h
Outdated
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
jeremyhylton
pushed a commit
to jeremyhylton/cpython
that referenced
this pull request
Aug 19, 2024
blhsing
pushed a commit
to blhsing/cpython
that referenced
this pull request
Aug 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to our stats the CALL_KW opcode is one of the most common opcodes that prevents projection of tier 2 traces.
Making CALL_KW suitable for tier 2 is infeasible, but we can specialize it in tier 1 such that the specializations can be handled by tier 2.
This PR adds three specializations: