FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.13] gh-116608: Revert "[3.13] gh-116608: Apply style and compatibility changes from importlib_resources. (GH-123028) (#123051)" by jaraco · Pull Request #123072 · python/cpython · GitHub

/ cpython Public

[3.13] gh-116608: Revert "[3.13] gh-116608: Apply style and compatibility changes from importlib_resources. (GH-123028) (#123051)" - #123072

Closed
jaraco wants to merge 1 commit into
python:3.13from
jaraco:revert-123051
ConversationCommits (1)ChecksFiles changed
Closed

[3.13] gh-116608: Revert "[3.13] gh-116608: Apply style and compatibility changes from importlib_resources. (GH-123028) (#123051)"#123072
jaraco wants to merge 1 commit into
python:3.13from
jaraco:revert-123051

Conversation

jaraco commented Aug 16, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

This reverts commit 5ac14ee.

This commit should be re-applied after 3.13.0 final.

[3.13] pythongh-116608: Revert "[3.13] pythongh-116608: Apply style a…
0a058bc 
…nd compatibility changes from importlib_resources. (pythonGH-123028) (python#123051)"

This reverts commit 5ac14ee.

This commit should be re-applied after 3.13.0 final.
jaraco requested review from FFY00 and warsaw as code owners August 16, 2024 15:53
bedevere-app Bot mentioned this pull request Aug 16, 2024
Merged
bedevere-app Bot mentioned this pull request Aug 16, 2024
Open
jaraco enabled auto-merge (squash) August 16, 2024 15:59
jaraco disabled auto-merge August 16, 2024 16:11

jaraco commented Aug 16, 2024

Copy link
Copy Markdown
Member Author

I guess technically this change should also be reviewed.

jaraco requested review from encukou and removed request for FFY00 and warsaw August 16, 2024 16:12

FFY00 commented Aug 16, 2024

Copy link
Copy Markdown
Member

@jaraco feel free to request a review from me in such cases. I do tend to keep up with the ongoing work in the importlib_metadata and importlib_resources backports, so it might be easier for me to have a look compared to others.

jaraco commented Aug 17, 2024

Copy link
Copy Markdown
Member Author

An alternative to approving and merging this change could be to retroactively review and accept the changes for 3.13. I know we wouldn't normally apply such style-sync changes in an RC, but I also note that the AST doesn't change for the non-test code and changes only very modestly in tests. If @encukou would be okay with not applying this PR, that would be my preference.

encukou commented Aug 19, 2024

Copy link
Copy Markdown
Member

I agree that, since the mistake is made, it's better to keep the style changes in than to revert them and re-introduce later.
@Yhg1s, do you agree?

Yhg1s commented Sep 2, 2024

Copy link
Copy Markdown
Member

Yes, the changes seem benign enough that there's no point in reverting and reapplying.

Yhg1s closed this Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

encukou Awaiting requested review from encukou

Assignees

No one assigned

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL