Repository navigation
gh-123048: Fix missing source location in pattern matching code - #123167
Merged
iritkatriel merged 1 commit intoAug 20, 2024
Merged
iritkatriel merged 1 commit into
iritkatriel merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
markshannon
approved these changes
Aug 20, 2024
markshannon
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Nice clean fix.
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 20, 2024
…pythonGH-123167) (cherry picked from commit bffed80) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
Copy link
Copy Markdown
|
GH-123169 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 20, 2024
…pythonGH-123167) (cherry picked from commit bffed80) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
Copy link
Copy Markdown
|
GH-123170 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
iritkatriel
added a commit
that referenced
this pull request
Aug 20, 2024
blhsing
pushed a commit
to blhsing/cpython
that referenced
this pull request
Aug 22, 2024
iritkatriel
added a commit
that referenced
this pull request
Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Threading doesn't work for JUMP_NO_INTERRUPT. In this case it doesn't need to be JUMP_NO_INTERRUPT anyway because it's a forward jump so it makes no difference to the final bytecode.