FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-123165: make `dis` functions render positions on demand by picnixz · Pull Request #123168 · python/cpython · GitHub

/ cpython Public

gh-123165: make dis functions render positions on demand - #123168

Merged
iritkatriel merged 30 commits into
python:mainfrom
picnixz:dis-show-positions-123165
Aug 21, 2024
ConversationCommits (30)ChecksFiles changed
Merged

gh-123165: make dis functions render positions on demand#123168
iritkatriel merged 30 commits into
python:mainfrom
picnixz:dis-show-positions-123165

Conversation

picnixz commented Aug 20, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Aug 20, 2024
Closed
picnixz force-pushed the dis-show-positions-123165 branch from be826a5 to a934b4e Compare August 20, 2024 11:36
picnixz force-pushed the dis-show-positions-123165 branch from a934b4e to a8eab11 Compare August 20, 2024 11:36
picnixz marked this pull request as ready for review August 20, 2024 12:38
picnixz removed the skip news label Aug 20, 2024
iritkatriel reviewed Aug 20, 2024
View reviewed changes

iritkatriel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good. A few comments.

Comment thread Doc/library/dis.rst Outdated
Comment thread Doc/whatsnew/3.14.rst Outdated
Comment thread Lib/dis.py Outdated
Comment thread Lib/dis.py Outdated
Comment thread Lib/dis.py Outdated
Comment thread Lib/test/test_dis.py Outdated
Comment thread Lib/dis.py Outdated
picnixz requested a review from iritkatriel August 20, 2024 17:25
picnixz changed the title gh-123165: add the show_positions formal parameter to dis functions gh-123165: make dis functions render positions on demand Aug 21, 2024
iritkatriel reviewed Aug 21, 2024
View reviewed changes

iritkatriel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Cool. A few more comments, nothing major.

Comment thread Doc/library/dis.rst Outdated
Comment thread Doc/library/dis.rst Outdated
Comment thread Doc/library/dis.rst
Comment thread Doc/library/dis.rst Outdated
Comment thread Doc/whatsnew/3.14.rst Outdated
Comment thread Lib/dis.py Outdated
Comment thread Lib/dis.py Outdated
picnixz force-pushed the dis-show-positions-123165 branch from 112fe26 to ca3cf87 Compare August 21, 2024 10:02
picnixz force-pushed the dis-show-positions-123165 branch from 548b30f to 9117895 Compare August 21, 2024 10:10
picnixz mentioned this pull request Aug 21, 2024
Merged
iritkatriel reviewed Aug 21, 2024
View reviewed changes

iritkatriel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Getting there. Some doc tweaks and a question.

Comment thread Doc/whatsnew/3.14.rst Outdated
Comment thread Lib/dis.py Outdated
Comment thread Lib/dis.py Outdated
Comment thread Lib/dis.py Outdated
Comment thread Lib/dis.py Outdated

picnixz commented Aug 21, 2024

Copy link
Copy Markdown
Member Author

I marked your comments as resolved but I hoped I didn't miss any. By the way, thank you very much for your help @iritkatriel!

iritkatriel commented Aug 21, 2024

Copy link
Copy Markdown
Member

LGTM. @markshannon is this what you had in mind?

markshannon commented Aug 21, 2024

Copy link
Copy Markdown
Member

Yes

iritkatriel merged commit b1d3bd2 into python:main Aug 21, 2024

iritkatriel commented Aug 21, 2024

Copy link
Copy Markdown
Member

Thank you @picnixz !

picnixz deleted the dis-show-positions-123165 branch August 21, 2024 13:50

picnixz commented Aug 21, 2024

Copy link
Copy Markdown
Member Author

Thank you for your review as well, Irit!

blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
pythongh-123165: make dis functions render positions on demand (pyt…
966626a 
…hon#123168)
picnixz mentioned this pull request Dec 5, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

iritkatriel iritkatriel approved these changes
markshannon Awaiting requested review from markshannon

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL