GH-118093: Specialize calls to non-vectorcall classes as CALL_NON_PY_GENERAL - #123212
Merged
markshannon merged 1 commit intoAug 22, 2024
Merged
GH-118093: Specialize calls to non-vectorcall classes as CALL_NON_PY_GENERAL#123212markshannon merged 1 commit into
markshannon merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
3 tasks
markshannon
approved these changes
Aug 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Super minor change to the specializer. Performance impact is in the noise, but the stats indicate that this decreases our tier one instructions by 4% and increases our tier two instructions by 2%. It also gets rid of (basically) all unspecialized CALL instructions.