FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Merge TSAN test matrices in CI by webknjaz · Pull Request #123278 · python/cpython · GitHub

/ cpython Public

Merge TSAN test matrices in CI - #123278

Merged
hugovk merged 2 commits into
python:mainfrom
webknjaz:maintenance/gha-tsan-reusable
Jan 29, 2025
ConversationCommits (2)ChecksFiles changed
Merged

Merge TSAN test matrices in CI#123278
hugovk merged 2 commits into
python:mainfrom
webknjaz:maintenance/gha-tsan-reusable

Conversation

webknjaz commented Aug 24, 2024

Copy link
Copy Markdown
Member

Previously, they were duplicated, with custom commands being passed to the same reusable workflow. This patch moves the commands in and adds a matrix resembling the interface of other reusable workflows.

webknjaz commented Aug 24, 2024

Copy link
Copy Markdown
Member Author

@hugovk still conflicted about what to do with the skipped job names but figured I'd reshape another test job pair to have the same structure..

webknjaz commented Aug 26, 2024
View reviewed changes
Comment thread .github/workflows/reusable-tsan.yml
webknjaz force-pushed the maintenance/gha-tsan-reusable branch from 5779c18 to 648f35a Compare January 27, 2025 23:32
webknjaz requested a review from AA-Turner as a code owner January 27, 2025 23:32
webknjaz commented Jan 27, 2025
View reviewed changes
Comment thread .github/workflows/build.yml
with:
config_hash: ${{ needs.check_source.outputs.config_hash }}
options: ./configure --config-cache --with-thread-sanitizer --with-pydebug
suppressions_path: Tools/tsan/supressions.txt

webknjaz Jan 27, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

NOTE: there was a typo in the filename, so this patch also fixes that.

s/supressions.txt/suppressions.txt/

webknjaz Jan 27, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

So this is what was causing the CI job to fail: #123278 (comment)

Merge TSAN test matrices in CI
7593210 
Previously, they were duplicated, with custom commands being passed to
the same reusable workflow. This patch moves the commands in and adds
a matrix resembling the interface of other reusable workflows.
Fix spelling of Tools/tsan/suppressions.txt
d6fe871 
A `p` was missing before this patch. And now it doesn't.
webknjaz force-pushed the maintenance/gha-tsan-reusable branch from b0fc735 to d6fe871 Compare January 27, 2025 23:55

webknjaz commented Jan 27, 2025

Copy link
Copy Markdown
Member Author

@hugovk this should be ready for the final review and merge now that I've found and addressed the problem.

webknjaz closed this Jan 28, 2025
webknjaz reopened this Jan 28, 2025

webknjaz commented Jan 28, 2025

Copy link
Copy Markdown
Member Author

Looks like there's some flaky ASAN tests, so I reopened the PR to retrigger the CI: https://github.com/python/cpython/actions/runs/13000662810/job/36258482466?pr=123278#step:16:877

hugovk approved these changes Jan 28, 2025
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks! I think we only need to backport this to 3.13?

cc @corona10

hugovk added the needs backport to 3.13 bugs and security fixes label Jan 28, 2025

webknjaz commented Jan 28, 2025

Copy link
Copy Markdown
Member Author

@hugovk personally, I think that CI updates should be ported as far back as possible to facilitate any future backports in terms of conflicts.

hugovk commented Jan 29, 2025

Copy link
Copy Markdown
Member

Yeah, let's try to 3.12 then, but I expect conflicts :)

hugovk added the needs backport to 3.12 only security fixes label Jan 29, 2025
hugovk merged commit 03d9cdb into python:main Jan 29, 2025

miss-islington-app Bot commented Jan 29, 2025

Copy link
Copy Markdown

Thanks @webknjaz for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington-app Bot commented Jan 29, 2025

Copy link
Copy Markdown

Sorry, @webknjaz and @hugovk, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 03d9cdb7298cdbf67535dfeb3af5c1a619be7580 3.13

miss-islington-app Bot commented Jan 29, 2025

Copy link
Copy Markdown

Sorry, @webknjaz and @hugovk, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 03d9cdb7298cdbf67535dfeb3af5c1a619be7580 3.12

webknjaz added a commit to webknjaz/cpython that referenced this pull request Feb 5, 2025
Merge TSAN test matrices in CI (python#123278)
e8f2d3d 
(cherry picked from commit 03d9cdb)
webknjaz added a commit to webknjaz/cpython that referenced this pull request Feb 5, 2025
Merge TSAN test matrices in CI (python#123278)
e2a2c83 
(cherry picked from commit 03d9cdb)

webknjaz commented Feb 5, 2025

Copy link
Copy Markdown
Member Author

3.13: #129673
3.12: #129674

bedevere-app Bot commented Feb 6, 2025

Copy link
Copy Markdown

GH-129673 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Feb 6, 2025

bedevere-app Bot commented Feb 6, 2025

Copy link
Copy Markdown

GH-129674 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Feb 6, 2025
hugovk pushed a commit that referenced this pull request Feb 6, 2025
[3.13] Merge TSAN test matrices in CI (#123278) (#129673)
b5eed8c
webknjaz added a commit to webknjaz/cpython that referenced this pull request Feb 6, 2025
Merge TSAN test matrices in CI (python#123278)
f3abee0 
(cherry picked from commit 03d9cdb)
hugovk pushed a commit that referenced this pull request Feb 6, 2025
[3.12] Merge TSAN test matrices in CI (#123278) (#129674)
895e23d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk approved these changes
ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

hugovk

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL