Repository navigation
[WIP] bpo-36287: Ignoring optional field. - #12328
Closed
eamanu wants to merge 3 commits into
Closed
eamanu wants to merge 3 commits into
eamanu wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
To avoid unnecessary verbose this PR add and `if` to know if the field to return is not None
matrixise
suggested changes
Mar 15, 2019
Comment thread
Lib/ast.py
Outdated
Copy link
Copy Markdown
Member
|
Why is this a WIP? If this truly isn't ready to be considered for review then please close the PR. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Hi @brettcannon. I will close it now. I am working on this Issue, but you are right, when I have the "final" PR I will open it again. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid unnecessary verbose this PR add and if to know
if the field to return is not None
https://bugs.python.org/issue36287