FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-82378: document the difference between sys.tracebacklimit and the limit arguments by cfbolz · Pull Request #123286 · python/cpython · GitHub

/ cpython Public

gh-82378: document the difference between sys.tracebacklimit and the limit arguments - #123286

Merged
pablogsal merged 3 commits into
python:mainfrom
cfbolz:gh-82378-traceback-limit-docs
Aug 25, 2024
ConversationCommits (3)ChecksFiles changed
Merged

gh-82378: document the difference between sys.tracebacklimit and the limit arguments#123286
pablogsal merged 3 commits into
python:mainfrom
cfbolz:gh-82378-traceback-limit-docs

Conversation

cfbolz commented Aug 24, 2024 •
edited by hugovk
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot mentioned this pull request Aug 24, 2024
Closed
bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting core review labels Aug 24, 2024
cfbolz requested a review from pablogsal August 24, 2024 12:18

pablogsal commented Aug 24, 2024

Copy link
Copy Markdown
Member

I think this is good but as this it's tricky territory I would like @hugovk to see if he can suggest any improvement to the location or the wording

picnixz approved these changes Aug 25, 2024
View reviewed changes

picnixz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

NIT: removing a double space.

Comment thread Doc/library/traceback.rst Outdated
Update Doc/library/traceback.rst
0de4934 
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

cfbolz commented Aug 25, 2024

Copy link
Copy Markdown
Contributor Author

@picnixz thanks!

hugovk reviewed Aug 25, 2024
View reviewed changes
Comment thread Doc/library/traceback.rst Outdated
Update Doc/library/traceback.rst
a227ce5 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
hugovk approved these changes Aug 25, 2024
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

pablogsal merged commit 70bfef5 into python:main Aug 25, 2024

miss-islington-app Bot commented Aug 25, 2024

Copy link
Copy Markdown

Thanks @cfbolz for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 25, 2024
pythongh-82378: Document the difference between sys.tracebacklimit an…
6c52b1d 
…d the limit arguments (pythonGH-123286)

(cherry picked from commit 70bfef5)

Co-authored-by: CF Bolz-Tereick <cfbolz@gmx.de>

bedevere-app Bot commented Aug 25, 2024

Copy link
Copy Markdown

GH-123325 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Aug 25, 2024
pablogsal added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Aug 25, 2024

miss-islington-app Bot commented Aug 25, 2024

Copy link
Copy Markdown

Thanks @cfbolz for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington-app Bot commented Aug 25, 2024

Copy link
Copy Markdown

Thanks @cfbolz for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 25, 2024
pythongh-82378: Document the difference between sys.tracebacklimit an…
50260e9 
…d the limit arguments (pythonGH-123286)

(cherry picked from commit 70bfef5)

Co-authored-by: CF Bolz-Tereick <cfbolz@gmx.de>

bedevere-app Bot commented Aug 25, 2024

Copy link
Copy Markdown

GH-123326 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 25, 2024
pythongh-82378: Document the difference between sys.tracebacklimit an…
5ee8962 
…d the limit arguments (pythonGH-123286)

(cherry picked from commit 70bfef5)

Co-authored-by: CF Bolz-Tereick <cfbolz@gmx.de>
bedevere-app Bot removed the needs backport to 3.12 only security fixes label Aug 25, 2024
pablogsal pushed a commit that referenced this pull request Aug 25, 2024
[3.12] gh-82378: Document the difference between sys.tracebacklimit a…
ffa282c 
…nd the limit arguments (GH-123286) (#123326)

gh-82378: Document the difference between sys.tracebacklimit and the limit arguments (GH-123286)
(cherry picked from commit 70bfef5)

Co-authored-by: CF Bolz-Tereick <cfbolz@gmx.de>
pablogsal pushed a commit that referenced this pull request Aug 25, 2024
[3.13] gh-82378: Document the difference between sys.tracebacklimit a…
4817365 
…nd the limit arguments (GH-123286) (#123325)

gh-82378: Document the difference between sys.tracebacklimit and the limit arguments (GH-123286)
(cherry picked from commit 70bfef5)

Co-authored-by: CF Bolz-Tereick <cfbolz@gmx.de>
hugovk removed the needs backport to 3.13 bugs and security fixes label Feb 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

picnixz picnixz approved these changes
hugovk hugovk approved these changes
pablogsal pablogsal approved these changes

Assignees

No one assigned

Labels

awaiting merge docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL