Repository navigation
gh-123177: Fix prompt for wrapped lines in pyrepl - #123324
Merged
pablogsal merged 1 commit intoAug 25, 2024
Merged
pablogsal merged 1 commit into
pablogsal merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
When display lines above the cursor come from the cache, the first line to not come from the cache may be a wrapped line, starting half way through a logical line in the buffer. Detect and handle this case to avoid accidentally drawing a stray prompt in the middle of a logical line.
godlygeek
requested review from
ambv,
lysnikolaou and
pablogsal
as code owners
August 25, 2024 22:29
pablogsal
approved these changes
Aug 25, 2024
Copy link
Copy Markdown
Member
|
Tested locally in a bunch of different terminals and also checked that doesn't impact performance of Frankenstein pasting :) |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks @godlygeek for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 25, 2024
) When display lines above the cursor come from the cache, the first line to not come from the cache may be a wrapped line, starting half way through a logical line in the buffer. Detect and handle this case to avoid accidentally drawing a stray prompt in the middle of a logical line. (cherry picked from commit 602fcf9) Co-authored-by: Matt Wozniski <mwozniski@bloomberg.net>
Copy link
Copy Markdown
|
GH-123327 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
pablogsal
pushed a commit
that referenced
this pull request
Aug 26, 2024
…123327) gh-123177: Fix prompt for wrapped lines in pyrepl (GH-123324) When display lines above the cursor come from the cache, the first line to not come from the cache may be a wrapped line, starting half way through a logical line in the buffer. Detect and handle this case to avoid accidentally drawing a stray prompt in the middle of a logical line. (cherry picked from commit 602fcf9) Co-authored-by: Matt Wozniski <mwozniski@bloomberg.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When display lines above the cursor come from the cache, the first line to not come from the cache may be a wrapped line, starting half way through a logical line in the buffer. Detect and handle this case to avoid accidentally drawing a stray prompt in the middle of a logical line.