Repository navigation
ctypes: remove use of legacy unicode API - #12340
Merged
methane merged 4 commits intoApr 19, 2019
Merged
methane merged 4 commits into
methane merged 4 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
PyUnicode_AsUnicodeAndSize() -> PyUnicode_AsWideChar()
auvipy
approved these changes
Apr 17, 2019
brettcannon
reviewed
Apr 17, 2019
Comment thread
Modules/_ctypes/_ctypes.c
Outdated
Comment thread
Modules/_ctypes/_ctypes.c
Outdated
Comment thread
Modules/_ctypes/_ctypes.c
| // PyUnicode_AsWideChar() returns number of wchars including trailing NUL, | ||
| // when it is called with NULL. | ||
| if ((size_t)len-1 > self->b_size/sizeof(wchar_t)) { | ||
| PyErr_SetString(PyExc_ValueError, "string too long"); |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Is it worth providing in the exception message the provided length and what the max length actually is?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Maybe yes. But this file has similar codes which are not relating to wchar_t APIs. ("bytes string too long").
I want to keep this pull request simple.
Sorry, something went wrong.
Comment thread
Modules/_ctypes/cfield.c
Outdated
Co-Authored-By: methane <songofacandy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyUnicode_AsUnicodeAndSize() -> PyUnicode_AsWideChar()