FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-123142: fix too wide source location of GET_ITER/GET_AITER by iritkatriel · Pull Request #123420 · python/cpython · GitHub

/ cpython Public

gh-123142: fix too wide source location of GET_ITER/GET_AITER - #123420

Merged
iritkatriel merged 1 commit into
python:mainfrom
iritkatriel:iter_raises
Aug 28, 2024
ConversationCommits (1)ChecksFiles changed
Merged

gh-123142: fix too wide source location of GET_ITER/GET_AITER#123420
iritkatriel merged 1 commit into
python:mainfrom
iritkatriel:iter_raises

Conversation

iritkatriel commented Aug 28, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Aug 28, 2024
Closed
iritkatriel added type-bug An unexpected behavior, bug, or error interpreter-core (Objects, Python, Grammar, and Parser dirs) needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes skip news and removed awaiting core review labels Aug 28, 2024

iritkatriel commented Aug 28, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

Skipping news because the news item from #123173 covers this.

markshannon approved these changes Aug 28, 2024
View reviewed changes

markshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good.
Nice clean fix.

iritkatriel merged commit 61bef62 into python:main Aug 28, 2024

miss-islington-app Bot commented Aug 28, 2024

Copy link
Copy Markdown

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington-app Bot commented Aug 28, 2024

Copy link
Copy Markdown

Sorry, @iritkatriel, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 61bef6245c4a32bf430d684ede8603f423d63284 3.13

miss-islington-app Bot commented Aug 28, 2024

Copy link
Copy Markdown

Sorry, @iritkatriel, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 61bef6245c4a32bf430d684ede8603f423d63284 3.12

iritkatriel added a commit to iritkatriel/cpython that referenced this pull request Aug 28, 2024
[3.13] pythongh-123142: fix too wide source location of GET_ITER/GET_…
426c59e 
…AITER (pythonGH-123420).

(cherry picked from commit 61bef62)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>

bedevere-app Bot commented Aug 28, 2024

Copy link
Copy Markdown

GH-123435 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Aug 28, 2024
iritkatriel added a commit to iritkatriel/cpython that referenced this pull request Aug 28, 2024
[3.12] pythongh-123142: fix too wide source location of GET_ITER/GET_…
5786bc8 
…AITER (pythonGH-123420).

(cherry picked from commit 61bef62)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>

bedevere-app Bot commented Aug 28, 2024

Copy link
Copy Markdown

GH-123436 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Aug 28, 2024
iritkatriel added a commit that referenced this pull request Aug 28, 2024
[3.13] gh-123142: fix too wide source location of GET_ITER/GET_AITER (G…
d379a92 
…H-123420). (#123435)

(cherry picked from commit 61bef62)
iritkatriel added a commit that referenced this pull request Aug 28, 2024
[3.12] gh-123142: fix too wide source location of GET_ITER/GET_AITER (G…
0181aa2 
…H-123420). (#123436)

(cherry picked from commit 61bef62)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

markshannon markshannon approved these changes

Assignees

iritkatriel

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL