FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-123424: add `ZipInfo._for_archive` to set suitable default properties by picnixz · Pull Request #123429 · python/cpython · GitHub

/ cpython Public

gh-123424: add ZipInfo._for_archive to set suitable default properties - #123429

Merged
jaraco merged 8 commits into
python:mainfrom
picnixz:feat/zipfile-for-name-123424
Dec 29, 2024
ConversationCommits (8)ChecksFiles changed
Merged

gh-123424: add ZipInfo._for_archive to set suitable default properties#123429
jaraco merged 8 commits into
python:mainfrom
picnixz:feat/zipfile-for-name-123424

Conversation

picnixz commented Aug 28, 2024 •
edited by jaraco
Loading

Copy link
Copy Markdown
Member

picnixz requested a review from jaraco as a code owner August 28, 2024 14:20
bedevere-app Bot mentioned this pull request Aug 28, 2024
Closed
jaraco reviewed Aug 28, 2024
View reviewed changes

jaraco left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looking good. I have some thoughts about alternative approaches. Interested to hear what you think.

Comment thread Lib/zipfile/__init__.py Outdated
Comment thread Lib/zipfile/__init__.py Outdated

Wulian233 commented Nov 2, 2024

Copy link
Copy Markdown
Contributor

Is there anything else that needs to be changed/discussion in this PR? I had another PR #124435 (which has been completed) that conflicted with these changes.

After merge, I can continue handle my PR :)

#124435 (review)

picnixz commented Nov 2, 2024

Copy link
Copy Markdown
Member Author

I don't have time for this one sorry. I didn't implement the suggestion with composition due to other issues that seemed more pressing (and I don't plan to come back here before I'm done with providing HACL* HMAC, at least).

jaraco self-assigned this Dec 29, 2024
jaraco force-pushed the feat/zipfile-for-name-123424 branch from f578f66 to 44e7b75 Compare December 29, 2024 18:07
jaraco changed the title gh-123424: add ZipInfo.for_name to construct a ZipInfo for a file in an archive gh-123424: add ZipInfo._for_archive to set suitable default properties Dec 29, 2024
jaraco enabled auto-merge (squash) December 29, 2024 18:23
jaraco merged commit 7e819ce into python:main Dec 29, 2024

picnixz commented Dec 31, 2024

Copy link
Copy Markdown
Member Author

Thank you very much for taking over this @jaraco. Sorry for not honoring my initial commitment but I couldn't find the time/motivation to work on this one :(

picnixz deleted the feat/zipfile-for-name-123424 branch December 31, 2024 17:27

jaraco commented Dec 31, 2024

Copy link
Copy Markdown
Member

Thank you very much for taking over this @jaraco. Sorry for not honoring my initial commitment but I couldn't find the time/motivation to work on this one :(

No need to apologize. Thanks for the original work and being proactive about your availability.

srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
pythongh-123424: add ZipInfo._for_archive to set suitable default p…
7c0567d 
…roperties (python#123429)

---------

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
jaraco mentioned this pull request May 12, 2025
Closed
jaraco added a commit to jaraco/zipp that referenced this pull request May 12, 2025
Cherry-pick changes from python/cpython#123429.
bc37b6e 
python/cpython#123424: add `ZipInfo._for_archive` to set suitable default properties

---------

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
jaraco added a commit to jaraco/zipp that referenced this pull request May 12, 2025
Cherry-pick changes from python/cpython#123429.
511a7a3 
python/cpython#123424: add `ZipInfo._for_archive` to set suitable default properties

---------

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
jaraco mentioned this pull request May 26, 2025
Merged
jaraco added a commit to jaraco/zipp that referenced this pull request May 26, 2025
Merge pull request #142 from jaraco/backport-gh-123429
73cdd55 
Backport python/cpython#123429
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jaraco jaraco approved these changes

Assignees

jaraco

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Extract ZipInfo for archive functionality

3 participants

Back | FazBrowse Home | New Git URL