bpo-36127: Fix _PyArg_UnpackKeywords() warning - #12345
Conversation
Sorry, something went wrong.
Use Py_ssize_t type rather than int for the 'i' variable.
|
This change fix the following warning on Windows: c:\projects\cpython\python\getargs.c(2425): warning C4244: '=': conversion from 'Py_ssize_t' to 'int', possible loss of data [C:\projects\cpython\PCbuild\pythoncore.vcxproj] @serhiy-storchaka: Would you mind to review this change? |
Sorry, something went wrong.
|
I do not think this is the best way to fix this warning. All corresponding variables except nargs have type int, and I want to preserve this. |
Sorry, something went wrong.
Why is it wrong to use Py_ssize_t for 'i'? I don't want to use Py_ssize_t for other variables, since _PyParser uses int. Feel free to fix the warning differently. I only worry of having no compiler warning on Windows :-) |
Sorry, something went wrong.
|
Serhiy wrote a diffrent fix: PR #12353. |
Sorry, something went wrong.
Integrate the user-friendly features from PR python#16 by @picnixz into the automation support from PR python#45, making the CLI more intuitive: - Change --gh-issue to --issue, accepting multiple formats: * Plain numbers: --issue 12345 * With gh- prefix: --issue gh-12345 * GitHub URLs: --issue python/cpython#12345 - Add smart section matching with: * Case-insensitive matching: --section lib matches "Library" * Partial matching: --section doc matches "Documentation" * Common aliases: --section api matches "C API" * Separator normalization: --section core-and-builtins - Improve error messages for invalid sections This combines the automation features from PR python#45 with the interface improvements suggested by @picnixz in PR python#16, as reviewed by @hugovk and @larryhastings. Co-authored-by: picnixz <picnixz@users.noreply.github.com>
Integrate the user-friendly features from PR python#16 by @picnixz into the automation support from PR python#45, making the CLI more intuitive: - Change --gh-issue to --issue, accepting multiple formats: * Plain numbers: --issue 12345 * With gh- prefix: --issue gh-12345 * GitHub URLs: --issue python/cpython#12345 - Add smart section matching with: * Case-insensitive matching: --section lib matches "Library" * Partial matching: --section doc matches "Documentation" * Common aliases: --section api matches "C API" * Separator normalization: --section core-and-builtins - Improve error messages for invalid sections This combines the automation features from PR python#45 with the interface improvements suggested by @picnixz in PR python#16, as reviewed by @hugovk and @larryhastings.
Use Py_ssize_t type rather than int for the 'i' variable.
https://bugs.python.org/issue36127