gh-123430: Add dark mode support to pages generated by http.server - #123475
gh-123430: Add dark mode support to pages generated by http.server#123475hugovk merged 6 commits into
Conversation
Sorry, something went wrong.
The error pages and the directory lists generated by http.server did not allow browsers to enable the inbuilt dark mode. This change allows for that by setting the css property color-scheme properly.
|
All commit authors signed the Contributor License Agreement. |
Sorry, something went wrong.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead. |
Sorry, something went wrong.
…7wXl9.rst Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
hugovk
left a comment
There was a problem hiding this comment.
main
Testing ./python.exe -m http.server and looking at a directory listing and an error page:
It's the same in light and dark mode on Chrome with macOS.
PR
In dark mode:
And in light mode it's the same as main.
Sorry, something went wrong.
|
Should this get backported? The user seeing the incorrect color scheme sounds like a bug to me. |
Sorry, something went wrong.
It's a new feature, it should not be backported. |
Sorry, something went wrong.
|
@YorikHansen Please could you also mention this in What's New? https://docs.python.org/3.14/whatsnew/3.14.html#improved-modules |
Sorry, something went wrong.
|
Thank you! |
Sorry, something went wrong.
The error pages and the directory lists generated by http.server did not allow browsers to enable the inbuilt dark mode. This change allows for that by setting the css property color-scheme properly.