FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.13] gh-123091: Use _Py_IsImmortalLoose() (#123511) by vstinner · Pull Request #123600 · python/cpython · GitHub

/ cpython Public

[3.13] gh-123091: Use _Py_IsImmortalLoose() (#123511) - #123600

Merged
vstinner merged 1 commit into
python:3.13from
vstinner:bytes_immortal_loose13
Sep 2, 2024
ConversationCommits (1)ChecksFiles changed
Merged

[3.13] gh-123091: Use _Py_IsImmortalLoose() (#123511)#123600
vstinner merged 1 commit into
python:3.13from
vstinner:bytes_immortal_loose13

Conversation

vstinner commented Sep 2, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Use _Py_IsImmortalLoose() in bytesobject.c, typeobject.c and ceval.c.

(cherry picked from commit f1a0d96)

pythongh-123091: Use _Py_IsImmortalLoose() (python#123511)
8ddd09f 
Use _Py_IsImmortalLoose() in bytesobject.c, typeobject.c
and ceval.c.

(cherry picked from commit f1a0d96)
bedevere-app Bot mentioned this pull request Sep 2, 2024
Merged
bedevere-app Bot mentioned this pull request Sep 2, 2024
Closed

vstinner commented Sep 2, 2024

Copy link
Copy Markdown
Member Author

@encukou: Would you mind to review this backport to 3.13?

encukou approved these changes Sep 2, 2024
View reviewed changes

encukou left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This (probably) doesn't cover all the problematic uses of _Py_IsImmortal, but it's a step in the right direction.

vstinner commented Sep 2, 2024

Copy link
Copy Markdown
Member Author

This (probably) doesn't cover all the problematic uses of _Py_IsImmortal, but it's a step in the right direction.

If tomorrow, more issues will be open about this problem, I would suggest considering to change _Py_IsImmortal() to behave as _Py_IsImmortalLoose(). But for now, I prefer smaller changes by using _Py_IsImmortalLoose() instead.

vstinner merged commit 10735bf into python:3.13 Sep 2, 2024
vstinner deleted the bytes_immortal_loose13 branch September 2, 2024 13:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

encukou encukou approved these changes
markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL