gh-77894: Fix a crash when the GC breaks a loop containing a memoryview - #123898
Merged
serhiy-storchaka merged 2 commits intoSep 11, 2024
Merged
gh-77894: Fix a crash when the GC breaks a loop containing a memoryview#123898serhiy-storchaka merged 2 commits into
serhiy-storchaka merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…moryview Now a memoryview object can only be cleared if there are no buffers that refer it.
serhiy-storchaka
force-pushed
the
memoryview-clear
branch
from
3823a20 to
4e7d5c2
Compare
September 10, 2024 10:57
vstinner
approved these changes
Sep 10, 2024
vstinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Ah, test_pickle fails:
ERROR: test_non_continuous_buffer (test.test_pickle.PyPicklingErrorTests.test_non_continuous_buffer) (proto=5)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/test/pickletester.py", line 2330, in test_non_continuous_buffer
self.dumps(pb, proto)
~~~~~~~~~~^^^^^^^^^^^
File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/test/test_pickle.py", line 66, in dumps
p.dump(arg)
~~~~~~^^^^^
File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/pickle.py", line 499, in dump
self.save(obj)
~~~~~~~~~^^^^^
File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/pickle.py", line 572, in save
f(self, obj) # Call unbound method with explicit self
~^^^^^^^^^^^
File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/pickle.py", line 896, in save_picklebuffer
with obj.raw() as m:
~~~~~~~^^
BufferError: cannot extract raw buffer from non-contiguous buffer
|
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 11, 2024
…moryview (pythonGH-123898) Now a memoryview object can only be cleared if there are no buffers that refer it. (cherry picked from commit a1dbf2e) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Copy link
Copy Markdown
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict. cherry_picker a1dbf2ea69acc6ccee6292709af1dadd55c068be 3.12 |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-123936 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Sep 11, 2024
…ng a memoryview (pythonGH-123898) Now a memoryview object can only be cleared if there are no buffers that refer it. (cherry picked from commit a1dbf2e) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Copy link
Copy Markdown
|
GH-123937 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
serhiy-storchaka
added a commit
that referenced
this pull request
Sep 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now a memoryview object can only be cleared if there are no buffers that refer it.