Repository navigation
gh-123923: Defer refcounting for f_executable in _PyInterpreterFrame - #123924
Merged
colesbury merged 3 commits intoSep 12, 2024
Merged
colesbury merged 3 commits into
colesbury merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…terFrame` Use a `_PyStackRef` and defer the reference to `f_executable` when possible. This avoids some reference count contention in the common case of executing the same code object from multiple threads concurrently in the free-threaded build.
graingert
reviewed
Sep 10, 2024
Comment thread
Lib/test/test_generators.py
colesbury
marked this pull request as ready for review
September 10, 2024 23:34
colesbury
requested review from
Fidget-Spinner and
markshannon
as code owners
September 10, 2024 23:34
Fidget-Spinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I trust that you've run this with refleak tests? When I attempted this, there were a ton of refleaks.
Also one question. The rest looks good to me!
Sorry, something went wrong.
Comment thread
Objects/frameobject.c
Copy link
Copy Markdown
|
🤖 New build scheduled with the buildbot fleet by @colesbury for commit 9e7691a 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
Sorry, something went wrong.
Fidget-Spinner
approved these changes
Sep 11, 2024
Fidget-Spinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I think this makes sense now. Just one comment.
Sorry, something went wrong.
Comment thread
Modules/_testexternalinspection.c
Outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a _PyStackRef and defer the reference to f_executable when possible. This avoids some reference count contention in the common case of executing the same code object from multiple threads concurrently in the free-threaded build.