FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-36346: Prepare for removing the legacy Unicode C API. by serhiy-storchaka · Pull Request #12409 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-36346: Prepare for removing the legacy Unicode C API. - #12409

Closed
serhiy-storchaka wants to merge 32 commits into
python:mainfrom
serhiy-storchaka:disable-wchar-cache
ConversationCommits (32)ChecksFiles changed
Closed

bpo-36346: Prepare for removing the legacy Unicode C API.#12409
serhiy-storchaka wants to merge 32 commits into
python:mainfrom
serhiy-storchaka:disable-wchar-cache

Conversation

serhiy-storchaka commented Mar 18, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Add two compile time options: HAVE_UNICODE_WCHAR_CACHE and
USE_UNICODE_WCHAR_CACHE.

USE_UNICODE_WCHAR_CACHE makes the interpreter not using the
wchar_t cache and the legacy Unicode C API.

HAVE_UNICODE_WCHAR_CACHE removes the wchar_t cache and the
legacy Unicode C API that depends on it.

https://bugs.python.org/issue36346

bpo-36346: Prepare for removing the legacy Unicode C API.
699e616 
Add two compile time options: HAVE_UNICODE_WCHAR_CACHE and
USE_UNICODE_WCHAR_CACHE.

USE_UNICODE_WCHAR_CACHE makes the interpreter not using the
wchar_t cache and the legacy Unicode C API.

HAVE_UNICODE_WCHAR_CACHE removes the wchar_t cache and the
legacy Unicode C API that depends on it.
serhiy-storchaka requested review from a team, rhettinger and skrah as code owners March 18, 2019 14:27
scoder reviewed Mar 18, 2019
View reviewed changes

scoder left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Wow, that's a lot of code that will eventually be removed here. Nice!

Comment thread Modules/_ctypes/callproc.c
Comment thread Modules/_testcapimodule.c Outdated
Comment thread Modules/posixmodule.c Outdated

methane commented Jun 17, 2020

Copy link
Copy Markdown
Member

@serhiy-storchaka Would you split this pull request?
clinic should be updated before adding DeprecationWarning in PyArg_Parse*.

serhiy-storchaka commented Jun 29, 2020

Copy link
Copy Markdown
Member Author

@serhiy-storchaka Would you split this pull request?
clinic should be updated before adding DeprecationWarning in PyArg_Parse*.

#21223

methane reviewed Jul 6, 2020
View reviewed changes
Comment thread Include/cpython/unicodeobject.h Outdated

iritkatriel commented Apr 11, 2022

Copy link
Copy Markdown
Member

https://bugs.python.org/issue36346 is closed. What is the status of this PR?

rhettinger removed request for rhettinger and skrah May 3, 2022 06:23
serhiy-storchaka mentioned this pull request May 11, 2022
Merged

serhiy-storchaka commented May 12, 2022

Copy link
Copy Markdown
Member Author

No longer actual after merging #92537.

serhiy-storchaka deleted the disable-wchar-cache branch May 12, 2022 11:30
bedevere-bot mentioned this pull request Apr 10, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

methane methane left review comments
scoder scoder left review comments
+1 more reviewer
blesnatalman blesnatalman approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting core review DO-NOT-MERGE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL