FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-124120: Document `Annotated.__origin__` by sobolevn · Pull Request #124125 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-124120: Document Annotated.__origin__ - #124125

Merged
sobolevn merged 6 commits into
python:mainfrom
sobolevn:issue-124120
Sep 24, 2024
ConversationCommits (6)ChecksFiles changed
Merged

gh-124120: Document Annotated.__origin__#124125
sobolevn merged 6 commits into
python:mainfrom
sobolevn:issue-124120

Conversation

sobolevn commented Sep 16, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

sobolevn added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Sep 16, 2024
sobolevn requested a review from ncoghlan September 16, 2024 13:37
bedevere-app Bot mentioned this pull request Sep 16, 2024
Closed
bedevere-app Bot added docs Documentation in the Doc dir skip news labels Sep 16, 2024
sobolevn changed the title gh-124120: Document use of get_origin to access Annotated origin gh-124120: Document Annotated.__origin__ Sep 16, 2024
brianschubert reviewed Sep 16, 2024
View reviewed changes
Comment thread Doc/library/typing.rst Outdated
Update Doc/library/typing.rst
a9a3f74 
Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
AlexWaygood reviewed Sep 16, 2024
View reviewed changes
Comment thread Doc/library/typing.rst Outdated
Comment thread Doc/library/typing.rst Outdated
sobolevn and others added 2 commits September 16, 2024 19:20
Apply suggestions from code review
e8de2a5 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Fix tests
8994ed4
JelleZijlstra reviewed Sep 20, 2024
View reviewed changes

JelleZijlstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This change is fine but I don't like this long bulleted list of individual issues. We should rewrite it to a more organized form.

sobolevn commented Sep 20, 2024

Copy link
Copy Markdown
Member Author

We should rewrite it to a more organized form.

Ok, I will open an new issue for that!

This change is fine

So, I will merge it later today if no one else has any feedback.
Thank you!

sobolevn mentioned this pull request Sep 20, 2024
Closed
sobolevn merged commit faef3fa into python:main Sep 24, 2024

miss-islington-app Bot commented Sep 24, 2024

Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 24, 2024
pythongh-124120: Document Annotated.__origin__ (pythonGH-124125)
270c80f 
(cherry picked from commit faef3fa)

Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

bedevere-app Bot commented Sep 24, 2024

Copy link
Copy Markdown

GH-124416 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Sep 24, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 24, 2024
pythongh-124120: Document Annotated.__origin__ (pythonGH-124125)
bacb190 
(cherry picked from commit faef3fa)

Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

bedevere-app Bot commented Sep 24, 2024

Copy link
Copy Markdown

GH-124417 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Sep 24, 2024
sobolevn added a commit that referenced this pull request Sep 24, 2024
[3.12] gh-124120: Document Annotated.__origin__ (GH-124125) (#124417)
0c36c37 
gh-124120: Document `Annotated.__origin__` (GH-124125)
(cherry picked from commit faef3fa)

Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Yhg1s pushed a commit that referenced this pull request Sep 24, 2024
[3.13] gh-124120: Document Annotated.__origin__ (GH-124125) (#124416)
8c0c344 
gh-124120: Document `Annotated.__origin__` (GH-124125)
(cherry picked from commit faef3fa)

Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra left review comments
brianschubert brianschubert left review comments
AlexWaygood AlexWaygood left review comments
ncoghlan Awaiting requested review from ncoghlan

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL